Skip to content

Use PlatformVersion.Version as the server version #5486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Youssef1313 merged 1 commit into from
Apr 22, 2025
Merged

Use PlatformVersion.Version as the server version #5486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Platform/Microsoft.Testing.Platform/Hosts/ServerTestHost.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ namespace Microsoft.Testing.Platform.Hosts;

internal sealed partial class ServerTestHost : CommonTestHost, IServerTestHost, IDisposable, IOutputDeviceDataProducer
{
public const string ProtocolVersion = "1.0.0";
public const string ProtocolVersion = PlatformVersion.Version;
private readonly Func<TestFrameworkBuilderData, Task<ITestFramework>> _buildTestFrameworkAsync;

private readonly IMessageHandlerFactory _messageHandlerFactory;
Expand Down
3 changes: 1 addition & 2 deletions src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/PassiveNode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
// Licensed under the MIT license. See LICENSE file in the project root for full license information.

using Microsoft.Testing.Platform.Helpers;
using Microsoft.Testing.Platform.Hosts;
using Microsoft.Testing.Platform.Logging;
using Microsoft.Testing.Platform.Services;

Expand Down Expand Up @@ -63,7 +62,7 @@ public async Task<bool> ConnectAsync()
var requestMessage = (RequestMessage)message;
var responseObject = new InitializeResponseArgs(
ProcessId: _processHandler.GetCurrentProcess().Id,
ServerInfo: new ServerInfo("test-anywhere", Version: ServerTestHost.ProtocolVersion),
ServerInfo: new ServerInfo("test-anywhere", Version: PlatformVersion.Version),
Capabilities: new ServerCapabilities(
new ServerTestingCapabilities(
SupportsDiscovery: false,
Expand Down