-
Notifications
You must be signed in to change notification settings - Fork 293
Add net10.0 to SupportedNetFrameworks, drop net9.0 (EOL May 12 2026) #7976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,7 +29,7 @@ | |
| <ModernUwpMinimum>net9.0-windows10.0.17763.0</ModernUwpMinimum> | ||
| <WinUiMinimum>net8.0-windows10.0.18362.0</WinUiMinimum> | ||
|
|
||
| <SupportedNetFrameworks>net8.0;net9.0</SupportedNetFrameworks> | ||
| <SupportedNetFrameworks>net8.0;net10.0</SupportedNetFrameworks> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think we should do that. It's completely fine to still keep net9.0, and there is no obvious need to add net10.0. Users today can already target net10.0 and will be consuming our net9.0 artifacts without any problem. |
||
| </PropertyGroup> | ||
|
|
||
| <!-- Build config --> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,29 +1,29 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <Dependencies> | ||
| <ToolsetDependencies> | ||
| <Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="11.0.0-beta.26229.1"> | ||
| <Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="11.0.0-beta.26230.2"> | ||
| <Uri>https://github.com/dotnet/arcade</Uri> | ||
| <Sha>3ed6c23fee67b840de0fb5473ea6a95fc667b0a9</Sha> | ||
| <Sha>8a7b2d3d39078db20f33067c7929b88fdff4ee63</Sha> | ||
| </Dependency> | ||
| <Dependency Name="Microsoft.DotNet.Build.Tasks.Templating" Version="11.0.0-beta.26229.1"> | ||
| <Dependency Name="Microsoft.DotNet.Build.Tasks.Templating" Version="11.0.0-beta.26230.2"> | ||
| <Uri>https://github.com/dotnet/arcade</Uri> | ||
| <Sha>3ed6c23fee67b840de0fb5473ea6a95fc667b0a9</Sha> | ||
| <Sha>8a7b2d3d39078db20f33067c7929b88fdff4ee63</Sha> | ||
| </Dependency> | ||
| <Dependency Name="Microsoft.DotNet.XliffTasks" Version="11.0.0-beta.26229.1"> | ||
| <Dependency Name="Microsoft.DotNet.XliffTasks" Version="11.0.0-beta.26230.2"> | ||
| <Uri>https://github.com/dotnet/arcade</Uri> | ||
| <Sha>3ed6c23fee67b840de0fb5473ea6a95fc667b0a9</Sha> | ||
| <Sha>8a7b2d3d39078db20f33067c7929b88fdff4ee63</Sha> | ||
| </Dependency> | ||
| <Dependency Name="Microsoft.Testing.Extensions.CodeCoverage" Version="18.8.0-preview.26229.1"> | ||
| <Uri>https://dev.azure.com/devdiv/DevDiv/_git/vs-code-coverage</Uri> | ||
| <Sha>6b29c14c934bae1e26c21961b7e5ad1a25c4d3c5</Sha> | ||
| </Dependency> | ||
| <Dependency Name="MSTest" Version="4.3.0-preview.26229.1"> | ||
| <Dependency Name="MSTest" Version="4.3.0-preview.26230.4"> | ||
| <Uri>https://github.com/microsoft/testfx</Uri> | ||
| <Sha>0da10c24091f1ad35610ac05dd5aa7bd3ea79dd5</Sha> | ||
| <Sha>e6af9df44f1c17bcae2798b15388641609add3a3</Sha> | ||
| </Dependency> | ||
| <Dependency Name="Microsoft.Testing.Platform" Version="2.3.0-preview.26229.1"> | ||
| <Dependency Name="Microsoft.Testing.Platform" Version="2.3.0-preview.26230.4"> | ||
| <Uri>https://github.com/microsoft/testfx</Uri> | ||
| <Sha>0da10c24091f1ad35610ac05dd5aa7bd3ea79dd5</Sha> | ||
| <Sha>e6af9df44f1c17bcae2798b15388641609add3a3</Sha> | ||
| </Dependency> | ||
| </ToolsetDependencies> | ||
| </Dependencies> |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # `eng/common` | ||
|
|
||
| Files under `eng/common` come from [Arcade](https://github.com/dotnet/arcade). | ||
| Edits in `eng/common` will be overwritten by automation unless the changes are made directly in the Arcade repository. | ||
| For more information, see the [Arcade documentation](https://github.com/dotnet/arcade/tree/main/Documentation). |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,7 +37,7 @@ | |
| "runner": "Microsoft.Testing.Platform" | ||
| }, | ||
| "msbuild-sdks": { | ||
| "Microsoft.DotNet.Arcade.Sdk": "11.0.0-beta.26229.1", | ||
| "Microsoft.DotNet.Arcade.Sdk": "11.0.0-beta.26230.2", | ||
| "MSBuild.Sdk.Extras": "3.0.44" | ||
|
Comment on lines
39
to
41
|
||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ModernUwpMinimumis still set to anet9.0-*TFM. Because several projects include$(ModernUwpMinimum)in theirTargetFrameworks, this change will still build/pack a net9.0 target even thoughSupportedNetFrameworksdropped net9.0. If the intent is to fully drop net9.0, updateModernUwpMinimumaccordingly (or adjust the PR title/description to clarify that net9.0 is still required for Modern UWP).