Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
<ModernUwpMinimum>net9.0-windows10.0.17763.0</ModernUwpMinimum>
<WinUiMinimum>net8.0-windows10.0.18362.0</WinUiMinimum>

<SupportedNetFrameworks>net8.0;net9.0</SupportedNetFrameworks>
<SupportedNetFrameworks>net8.0;net10.0</SupportedNetFrameworks>
Comment on lines 29 to +32
Copy link

Copilot AI May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ModernUwpMinimum is still set to a net9.0-* TFM. Because several projects include $(ModernUwpMinimum) in their TargetFrameworks, this change will still build/pack a net9.0 target even though SupportedNetFrameworks dropped net9.0. If the intent is to fully drop net9.0, update ModernUwpMinimum accordingly (or adjust the PR title/description to clarify that net9.0 is still required for Modern UWP).

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should do that. It's completely fine to still keep net9.0, and there is no obvious need to add net10.0.

Users today can already target net10.0 and will be consuming our net9.0 artifacts without any problem.

</PropertyGroup>

<!-- Build config -->
Expand Down
20 changes: 10 additions & 10 deletions eng/Version.Details.xml
Original file line number Diff line number Diff line change
@@ -1,29 +1,29 @@
<?xml version="1.0" encoding="utf-8"?>
<Dependencies>
<ToolsetDependencies>
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="11.0.0-beta.26229.1">
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="11.0.0-beta.26230.2">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>3ed6c23fee67b840de0fb5473ea6a95fc667b0a9</Sha>
<Sha>8a7b2d3d39078db20f33067c7929b88fdff4ee63</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.Build.Tasks.Templating" Version="11.0.0-beta.26229.1">
<Dependency Name="Microsoft.DotNet.Build.Tasks.Templating" Version="11.0.0-beta.26230.2">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>3ed6c23fee67b840de0fb5473ea6a95fc667b0a9</Sha>
<Sha>8a7b2d3d39078db20f33067c7929b88fdff4ee63</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.XliffTasks" Version="11.0.0-beta.26229.1">
<Dependency Name="Microsoft.DotNet.XliffTasks" Version="11.0.0-beta.26230.2">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>3ed6c23fee67b840de0fb5473ea6a95fc667b0a9</Sha>
<Sha>8a7b2d3d39078db20f33067c7929b88fdff4ee63</Sha>
</Dependency>
<Dependency Name="Microsoft.Testing.Extensions.CodeCoverage" Version="18.8.0-preview.26229.1">
<Uri>https://dev.azure.com/devdiv/DevDiv/_git/vs-code-coverage</Uri>
<Sha>6b29c14c934bae1e26c21961b7e5ad1a25c4d3c5</Sha>
</Dependency>
<Dependency Name="MSTest" Version="4.3.0-preview.26229.1">
<Dependency Name="MSTest" Version="4.3.0-preview.26230.4">
<Uri>https://github.com/microsoft/testfx</Uri>
<Sha>0da10c24091f1ad35610ac05dd5aa7bd3ea79dd5</Sha>
<Sha>e6af9df44f1c17bcae2798b15388641609add3a3</Sha>
</Dependency>
<Dependency Name="Microsoft.Testing.Platform" Version="2.3.0-preview.26229.1">
<Dependency Name="Microsoft.Testing.Platform" Version="2.3.0-preview.26230.4">
<Uri>https://github.com/microsoft/testfx</Uri>
<Sha>0da10c24091f1ad35610ac05dd5aa7bd3ea79dd5</Sha>
<Sha>e6af9df44f1c17bcae2798b15388641609add3a3</Sha>
</Dependency>
</ToolsetDependencies>
</Dependencies>
6 changes: 3 additions & 3 deletions eng/Versions.props
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@
<PreReleaseVersionLabel>preview</PreReleaseVersionLabel>
</PropertyGroup>
<PropertyGroup Label="MSTest prod dependencies - darc updated">
<MicrosoftDotNetBuildTasksTemplatingPackageVersion>11.0.0-beta.26229.1</MicrosoftDotNetBuildTasksTemplatingPackageVersion>
<MicrosoftDotNetBuildTasksTemplatingPackageVersion>11.0.0-beta.26230.2</MicrosoftDotNetBuildTasksTemplatingPackageVersion>
<MicrosoftTestingExtensionsCodeCoverageVersion>18.8.0-preview.26229.1</MicrosoftTestingExtensionsCodeCoverageVersion>
<!-- empty line to avoid merge conflicts for darc PRs to update CC and MSTest+MTP -->
<MSTestVersion>4.3.0-preview.26229.1</MSTestVersion>
<MicrosoftTestingPlatformVersion>2.3.0-preview.26229.1</MicrosoftTestingPlatformVersion>
<MSTestVersion>4.3.0-preview.26230.4</MSTestVersion>
<MicrosoftTestingPlatformVersion>2.3.0-preview.26230.4</MicrosoftTestingPlatformVersion>
</PropertyGroup>
</Project>
5 changes: 5 additions & 0 deletions eng/common/AGENTS.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# `eng/common`

Files under `eng/common` come from [Arcade](https://github.com/dotnet/arcade).
Edits in `eng/common` will be overwritten by automation unless the changes are made directly in the Arcade repository.
For more information, see the [Arcade documentation](https://github.com/dotnet/arcade/tree/main/Documentation).
2 changes: 1 addition & 1 deletion global.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"runner": "Microsoft.Testing.Platform"
},
"msbuild-sdks": {
"Microsoft.DotNet.Arcade.Sdk": "11.0.0-beta.26229.1",
"Microsoft.DotNet.Arcade.Sdk": "11.0.0-beta.26230.2",
"MSBuild.Sdk.Extras": "3.0.44"
Comment on lines 39 to 41
Copy link

Copilot AI May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description states this is a single-property change in Directory.Build.props, but this PR also updates Arcade SDK + toolset dependency versions (and adds eng/common/AGENTS.md). Please update the PR description (or split into separate PRs) so reviewers/CI owners can clearly see why the dependency bumps are included.

Copilot uses AI. Check for mistakes.
}
}
Loading