Skip to content

Implement a FunctionLike interface #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
roblourens opened this issue Jul 19, 2017 · 5 comments
Closed

Implement a FunctionLike interface #162

roblourens opened this issue Jul 19, 2017 · 5 comments

Comments

@roblourens
Copy link
Member

See felixfbecker/php-language-server#438 (comment) and isFunctionLike in php-language-server's ParserHelpers.php
@jens1o
Copy link
Contributor

jens1o commented Aug 7, 2017

Am I wrong or is this a quite easy task?

I just add a new interface and map them to the points how the parserhelpers recognizes them?

@roblourens
Copy link
Member Author

Yes it would be quite easy.

@jens1o
Copy link
Contributor

jens1o commented Aug 7, 2017

I'm going to do this in the next minutes.

@roblourens
Copy link
Member Author

Ok, I started a stopwatch 😁

@jens1o
Copy link
Contributor

jens1o commented Aug 7, 2017

Quality before speed 😛

jens1o added a commit to jens1o/tolerant-php-parser that referenced this issue Aug 7, 2017
@jens1o
Add Functionlike interface
27c7b77 
microsoft#162
@jens1o jens1o mentioned this issue Aug 7, 2017
Merged
@dantleech dantleech mentioned this issue Sep 8, 2017
Closed
kant added a commit to kant/tolerant-php-parser that referenced this issue Mar 18, 2018
@kant
Typo on microsoft#162 & 283
eca2848
roblourens added a commit that referenced this issue Mar 18, 2018
@roblourens
Merge pull request #239 from kant/patch-1
967243e 
Typo on #162 & 283
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roblourens @jens1o