Skip to content

ClassLike Interface #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dantleech opened this issue Sep 8, 2017 · 1 comment
Closed

ClassLike Interface #171

dantleech opened this issue Sep 8, 2017 · 1 comment

Comments

@dantleech
Copy link
Contributor

dantleech commented Sep 8, 2017 •
edited
Loading

Similar to #162. Would it make sense to implement a ClassLike interface for ClassDeclaration, InterfaceDeclaration and TraitDeclaration ?
@roblourens
Copy link
Member

Yes, I think so. That kind of check does show up in several places like here https://github.com/felixfbecker/php-language-server/blob/master/src/DefinitionResolver.php#L1104.

@dantleech dantleech mentioned this issue Sep 8, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roblourens @dantleech