Skip to content

tests/generate_spec_tests.php generates file and folder names with backslashes on non-windows OSes #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TysonAndre opened this issue Feb 12, 2018 · 0 comments
Closed

tests/generate_spec_tests.php generates file and folder names with backslashes on non-windows OSes #224

TysonAndre opened this issue Feb 12, 2018 · 0 comments

Comments

@TysonAndre
Copy link
Contributor

Use DIRECTORY_SEPARATOR or / instead of "\". This is inconsistent with other test cases such as ParserGrammarTest.php

10:$outTestCaseDir = __DIR__ . "\\cases\\php-langspec\\";
12:file_put_contents($outTestCaseDir . "README.md", "Auto-generated from php/php-langspec tests");
roblourens added a commit that referenced this issue Feb 19, 2018
@roblourens
Merge pull request #235 from TysonAndre/fix-backslashes-unix
faca5af 
Fixes #224: Use DIRECTORY_SEPARATOR instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TysonAndre