Fix bugs and docs of FilePositionMap #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wasn't using some of those APIs for Node/Token, and didn't notice the incorrect phpdoc/code.
roblourens
requested changes
Feb 19, 2018
src/FilePositionMap.php
Outdated
| @@ -86,19 +86,23 @@ public function getEndLine($node) : int { | |||
| * Similar to getStartLine but includes the column | |||
| */ | |||
| public function getEndLineCharacterPositionForOffset($node) : LineCharacterPosition { | |||
| return $this->getLineCharacterPositionForOffset($node); | |||
| return $this->getLineCharacterPositionForOffset($node->getEndPosition()); | |||
There was a problem hiding this comment.
The other ForOffset methods take an actual offset, should this one have a different name?
There was a problem hiding this comment.
Also can $node have a type annotation?
There was a problem hiding this comment.
/**
* @param Node|Token $node
* Similar to getStartLine but includes the column
*/It has a phpdoc type annotation. It's used both for Node and Token, which have no common interface.
Renamed this method, the original name was incorrect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't using some of those APIs for Node/Token,
and didn't notice the incorrect phpdoc/code.