Fixes #103: Support parsing multiple exception types #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you publish a 0.0.12 release tag if this is merged? This will help when using this library with PHP 7.1+ codebases. |
Add a new array `otherQualifiedNameList` alongside qualifiedName to `CatchClause`. (Contains remaining `Token`s and `QualifiedName`s) (This design breaks backwards compatibility as little as possible) - A future backwards incompatible release should merge the two properties into `qualifiedNameList`, or something along those lines. Add a new helper method to parse the catch list. - The new helper is required because `tests/cases/php-langspec/exception_handling/odds_and_ends.php` should not fail because `catch (int $e)` is **syntactically** valid php (in 7.x), i.e. `php --syntax-check` doesn't reject it.
TysonAndre
force-pushed
the
multi-class-catch
branch
from
7054436 to
60d3fc5
Compare
|
Do the maintainers have any thoughts on this PR? E.g. documentation or additional tests that should be added? If this is merged, #107 can be closed. I think this should still become a list, just in a backwards incompatible change to 1.0 or 0.1 (e.g. the dependency https://github.com/felixfbecker/php-language-server/blob/master/composer.json#L28 of php-language-server would break if a name became a list of names)
|
|
Sorry, I promise I'll get to your PRs ASAP |
roblourens
approved these changes
May 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new array
otherQualifiedNameListalongside qualifiedNameto
CatchClause. (Contains remainingTokens andQualifiedNames)(This design breaks backwards compatibility as little as possible)
properties into
qualifiedNameList,or something along those lines.
Add a new helper method to parse the catch list.
tests/cases/php-langspec/exception_handling/odds_and_ends.phpshould not fail because
catch (int $e)is syntactically valid php(in 7.x), i.e.
php --syntax-checkdoesn't reject it.