Skip to content

Add MissingToken for missing QualifiedName #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2022
Merged

Add MissingToken for missing QualifiedName #379

merged 1 commit into from
Sep 25, 2022

Conversation

TysonAndre
Copy link
Contributor

And emit a diagnostic - these would be parse errors in php

@TysonAndre
Add MissingToken for missing QualifiedName
7e6cb20 
And emit a diagnostic - these would be parse errors in php
@TysonAndre
Copy link
Contributor Author

@roblourens - this is ready for review

@TysonAndre
Copy link
Contributor Author

@roblourens - thoughts?

@roblourens
Copy link
Member

Thanks! Sorry for taking so long to get back to these.

@roblourens roblourens merged commit 6f49c64 into microsoft:main Sep 25, 2022
@TysonAndre TysonAndre deleted the fix-base-clause branch September 25, 2022 19:18
@dantleech
Copy link
Contributor

dantleech commented Oct 3, 2022 •
edited
Loading

I think this causes a regression #390

@dantleech dantleech mentioned this pull request Oct 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roblourens roblourens roblourens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TysonAndre @roblourens @dantleech