Skip to content

Change getUri return type to nullable string #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2022
Merged

Change getUri return type to nullable string #383

merged 1 commit into from
Sep 25, 2022

Conversation

TysonAndre
Copy link
Contributor

Parser::parseSourceFile() accepts a nullable string $uri. Avoid a potential type error

@TysonAndre
Change getUri return type to nullable string
8ed21ce 
`Parser::parseSourceFile()` accepts a nullable string $uri.
Avoid a potential type error
@roblourens roblourens merged commit 1016890 into microsoft:main Sep 25, 2022
@TysonAndre TysonAndre deleted the source-file-node-nit branch September 25, 2022 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roblourens roblourens roblourens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TysonAndre @roblourens