Port "Fix getEffectiveCheckNode"
#1083
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Gabriela Araujo Britto <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Ports the fix for correctly identifying the effective node to check by centralizing outer‐expression skipping and adding support for satisfies expressions.
- Updated baseline error-location offsets in test fixtures for
satisfiessyntax - Extended
SkipOuterExpressionsand assertion utilities to recognizesatisfies - Refactored
getEffectiveCheckNodeto use the unifiedSkipOuterExpressionsflags
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| testdata/baselines/.../typeSatisfaction_errorLocations1.errors.txt.diff | Adjusted diff for updated error-location offsets |
| testdata/baselines/.../typeSatisfaction_errorLocations1.errors.txt | Updated baseline error positions |
| internal/transformers/typeeraser.go | Switched to new OEKAssertions mask in SkipOuterExpressions |
| internal/checker/checker.go | Replaced manual parentheses/satisfies logic in getEffectiveCheckNode |
| internal/ast/utilities.go | Introduced OEKSatisfies, bumped OEKExcludeJSDocTypeAssertion bit, and updated OEKAssertions and IsOuterExpression |
gabritto
reviewed
Jun 6, 2025
There was a problem hiding this comment.
This looks correctly ported, but I'm wondering why the JSDoc error baseline diff remains for arrowExpressionBodyJSDoc.error.txt: https://github.com/microsoft/typescript-go/blob/main/testdata/baselines/reference/submoduleAccepted/compiler/arrowExpressionBodyJSDoc.errors.txt.diff
@sandersn any idea why this is the case? Is this difference expected to remain forever, or are we missing some JSDoc thing still?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ports microsoft/TypeScript#60309