fix: fixes issue with tests not being found from template#3605
Merged
timotheeguerin merged 7 commits intomicrosoft:mainfrom Jul 8, 2024
Merged
fix: fixes issue with tests not being found from template#3605timotheeguerin merged 7 commits intomicrosoft:mainfrom
timotheeguerin merged 7 commits intomicrosoft:mainfrom
Conversation
jspears
requested review from
allenjzhang,
bterlson,
markcowl and
timotheeguerin
as code owners
Contributor
Author
|
@microsoft-github-policy-service agree |
timotheeguerin
approved these changes
Jul 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #3647
With node 22 the --test needs a glob to find files to test. As the docs a written the tests don't run or pass. This fixes it for me.