Typespec Generation for Empty Schema #4923#4934
Merged
chrisradek merged 5 commits intomicrosoft:mainfrom Nov 1, 2024
Merged
Conversation
JamesChen-us
requested review from
allenjzhang,
bterlson,
markcowl and
timotheeguerin
as code owners
microsoft-github-policy-service
bot
added
the
emitter:openapi3
Contributor
Author
@microsoft-github-policy-service agree |
Contributor
Author
|
@microsoft-github-policy-service agree |
chrisradek
reviewed
Nov 1, 2024
Member
chrisradek
left a comment
chrisradek
left a comment
There was a problem hiding this comment.
@JamesChen-us Thank you for creating this pull request and addressing the CI failures! I just had one minor comment on the changelog notes, but otherwise think this looks great!
.chronus/changes/fix-open-api-empty-schema-2024-10-1-6-50-22.md
Outdated
Show resolved
Hide resolved
chrisradek
approved these changes
Nov 1, 2024
Member
|
@JamesChen-us Thank you again for your contribution! Merging this now - this will be included in the next release! |
swatkatz
pushed a commit
to swatkatz/typespec
that referenced
this pull request
Nov 5, 2024
fix microsoft#4923 --------- Co-authored-by: Christopher Radek <14189820+chrisradek@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #4923