Rremove use of deprecated getDiscriminatedUnion in JS emitter#6306
Merged
timotheeguerin merged 9 commits intomicrosoft:mainfrom Mar 8, 2025
Merged
Conversation
joheredi
requested review from
AlitzelMendez,
MaryGao,
allenjzhang,
bterlson,
chrisradek,
markcowl,
qiaozha,
timotheeguerin,
timovv,
witemple-msft and
xirzec
as code owners
Collaborator
|
All changed packages have been documented.
Show changes
|
packages/http-client-js/test/e2e/http/type/property/additional-properties/spreads.test.ts
Show resolved
Hide resolved
Collaborator
|
You can try these changes here
|
joheredi
force-pushed
the
feature/remove-use-of-deprecated-union
branch
from
ff3226b to
8113be6
Compare
timotheeguerin
approved these changes
Mar 7, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
joheredi
force-pushed
the
feature/remove-use-of-deprecated-union
branch
from
e96f48e to
f7179e7
Compare
…ture/remove-use-of-deprecated-union
.chronus/changes/feature-remove-use-of-deprecated-union-2025-2-6-19-54-30.md
Show resolved
Hide resolved
archerzz
pushed a commit
to archerzz/typespec
that referenced
this pull request
Mar 10, 2025
…oft#6306) This change removed the use of the deprecated overload on the JS emitter and adds support for models in the `$.type.getDiscriminator` typekit --------- Co-authored-by: Timothee Guerin <tiguerin@microsoft.com> Co-authored-by: Timothee Guerin <timothee.guerin@outlook.com> # Conflicts: # pnpm-lock.yaml
dmnorc
pushed a commit
to dmnorc/typespec
that referenced
this pull request
Apr 9, 2025
…oft#6306) This change removed the use of the deprecated overload on the JS emitter and adds support for models in the `$.type.getDiscriminator` typekit --------- Co-authored-by: Timothee Guerin <tiguerin@microsoft.com> Co-authored-by: Timothee Guerin <timothee.guerin@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removed the use of the deprecated overload on the JS emitter and adds support for models in the
$.type.getDiscriminatortypekit