support nesting typekits#7108
Merged
timotheeguerin merged 4 commits intomicrosoft:mainfrom Apr 24, 2025
Merged
Conversation
added 2 commits
April 23, 2025 16:03
Contributor
|
All changed packages have been documented.
|
Collaborator
|
You can try these changes here
|
Member
|
Does this proxy wrap |
Member
Author
It doesn't - those values are returned if accessed prior to the wrapping logic. I added an assertion to the test case to make sure |
timotheeguerin
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7094
The caveat to this change is that you shouldn't have typekits that use regular fields.
For example -
$.foo.type<-- if this is a regular field that contains an object, then that object will be wrapped in a Proxy, breaking object identity.However, we follow the pattern of using
getdescriptors for this use-case instead, which would not break object identity.