Skip to content

Fix: Property getting wrongly finished when used inside union expression or operation inside interface template#7183

Merged
timotheeguerin merged 3 commits intomicrosoft:mainfrom
timotheeguerin:fix/finishing-template-declarations
Apr 30, 2025
Merged

Fix: Property getting wrongly finished when used inside union expression or operation inside interface template#7183
timotheeguerin merged 3 commits intomicrosoft:mainfrom
timotheeguerin:fix/finishing-template-declarations

Conversation

@timotheeguerin
Copy link
Copy Markdown
Member

@timotheeguerin timotheeguerin commented Apr 30, 2025

fix #7181

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 30, 2025

All changed packages have been documented.

  • @typespec/compiler
Show changes

@typespec/compiler - fix ✏️

Fix decorators on model properties getting wrongly called when checking the template declaration in the following cases,> - inside a union expression,> - under an non templated operation under a templated interface

Copy link
Copy Markdown
Member

@chrisradek chrisradek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the new test cases.

@azure-sdk
Copy link
Copy Markdown
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

@timotheeguerin timotheeguerin added this pull request to the merge queue Apr 30, 2025
Merged via the queue into microsoft:main with commit 6e554b8 Apr 30, 2025
21 checks passed
@timotheeguerin timotheeguerin deleted the fix/finishing-template-declarations branch April 30, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Templated interface still instantiate the operation and run their decorators

4 participants