Skip to content

Try to target right location for suppress codefix#8578

Merged
baywet merged 3 commits intomicrosoft:mainfrom
timotheeguerin:fix/suppress-codefix-wrong-location
Sep 26, 2025
Merged

Try to target right location for suppress codefix#8578
baywet merged 3 commits intomicrosoft:mainfrom
timotheeguerin:fix/suppress-codefix-wrong-location

Conversation

@timotheeguerin
Copy link
Copy Markdown
Member

@timotheeguerin timotheeguerin commented Sep 26, 2025

Fix issue where the suppression would get added to invalid location for directives

@microsoft-github-policy-service microsoft-github-policy-service bot added the compiler:core Issues for @typespec/compiler label Sep 26, 2025
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Sep 26, 2025

Open in StackBlitz

npm i https://pkg.pr.new/microsoft/typespec/@typespec/compiler@8578

commit: 33f6b8a

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 26, 2025

All changed packages have been documented.

  • @typespec/compiler
Show changes

@typespec/compiler - fix ✏️

Add suppression codefix looks up for the first valid parent

@azure-sdk
Copy link
Copy Markdown
Collaborator

azure-sdk commented Sep 26, 2025

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

Copy link
Copy Markdown
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I did manually validate that it fixes the issue for https://github.com/microsoft/openai-openapi-pr/pull/56

@baywet baywet enabled auto-merge September 26, 2025 19:35
@baywet baywet added this pull request to the merge queue Sep 26, 2025
Merged via the queue into microsoft:main with commit 6440860 Sep 26, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compiler:core Issues for @typespec/compiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants