Conversation
Co-authored-by: baywet <7905502+baywet@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [Bug]: OpenAPI import tool - additional properties import issue
Fix OpenAPI import: additionalProperties: true should generate Record<unknown>
Sep 26, 2025
Contributor
|
All changed packages have been documented.
Show changes
|
timotheeguerin
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an inconsistency in the OpenAPI import tool where
additionalProperties: trueandadditionalProperties: {}generated different TypeSpec types, despite having identical semantic meaning in OpenAPI 3.1.Problem
When importing an OpenAPI 3.1 specification with different
additionalPropertiesvalues:The conversion would produce inconsistent TypeSpec output:
Both
additionalProperties: trueandadditionalProperties: {}semantically mean "additional properties are allowed with any type" in OpenAPI, so they should generate the same TypeSpec representation.Solution
Updated the conversion logic in two places:
generate-types.ts: Modified thegetObjectTypemethod to explicitly handleadditionalProperties: trueby generatingRecord<unknown>transform-component-schemas.ts: Updated the schema transformation to preserveadditionalProperties: trueduring the conversion processResult
Both scenarios now correctly generate
Record<unknown>:Added comprehensive test coverage for both
additionalProperties: trueandadditionalProperties: {}scenarios to prevent regression.Fixes #[issue-number]
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
telemetry.astro.buildnode /home/REDACTED/work/typespec/typespec/website/node_modules/.bin/../astro/astro.js build(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.