Skip to content

Fix usage of set property in openapi and json schema emitter#8605

Merged
timotheeguerin merged 6 commits intomicrosoft:mainfrom
timotheeguerin:fix/set-object-builder
Oct 6, 2025
Merged

Fix usage of set property in openapi and json schema emitter#8605
timotheeguerin merged 6 commits intomicrosoft:mainfrom
timotheeguerin:fix/set-object-builder

Conversation

@timotheeguerin
Copy link
Copy Markdown
Member

fix #8590

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 29, 2025

All changed packages have been documented.

  • @typespec/asset-emitter
  • @typespec/json-schema
  • @typespec/openapi3
Show changes

@typespec/asset-emitter - deprecation ✏️

Deprecate use of ObjectBuilder#set in favor of setProperty,> diff lang=ts,> - builder.set("key", value);,> + setProperty(builder, "key", value);,>

@typespec/json-schema - fix ✏️

Fix crash when using a property called set

@typespec/openapi3 - fix ✏️

Fix crash when using a property called set

@azure-sdk
Copy link
Copy Markdown
Collaborator

azure-sdk commented Sep 29, 2025

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

@timotheeguerin timotheeguerin added this pull request to the merge queue Oct 6, 2025
Merged via the queue into microsoft:main with commit a7e52e1 Oct 6, 2025
26 checks passed
@timotheeguerin timotheeguerin deleted the fix/set-object-builder branch October 6, 2025 17:01
@baywet
Copy link
Copy Markdown
Member

baywet commented Oct 7, 2025

This PR has caused a major regression on the preview version, see #8675

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: @typespec/openapi3 emitter crashed when nested object having field name 'set'

4 participants