-
Notifications
You must be signed in to change notification settings - Fork 354
fix ICE in serializeValueAsJson #9804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
def4110
Initial plan
Copilot c71203f
fix(compiler): return undefined for unrecognized scalar constructor i…
Copilot e2f42d9
fix(compiler): only return undefined for no-arg scalar constructor, p…
Copilot d3d86c9
fix(compiler): return undefined for all unrecognized scalar construct…
Copilot b62632b
Merge branch 'main' into copilot/fix-ice-serialize-value-json
Copilot bd1bd7b
Merge branch 'main' into copilot/fix-ice-serialize-value-json
markcowl 5b6687b
test(openapi3): add test for known scalar constructors producing corr…
Copilot 4f77a59
chore: merge latest main changes (Fix to customized base type #9885)
Copilot c6d28ef
revert: remove inadvertent csharp emitter file changes from PR
Copilot bcf90d5
Merge branch 'main' into copilot/fix-ice-serialize-value-json
markcowl 3c311ce
Merge branch 'main' into copilot/fix-ice-serialize-value-json
markcowl 8bfc311
Update .chronus/changes/fix-ice-serialize-value-as-json-custom-scalar…
markcowl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
.chronus/changes/fix-ice-serialize-value-as-json-custom-scalar-2026-2-25-20-0-0.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| changeKind: fix | ||
| packages: | ||
| - "@typespec/compiler" | ||
| --- | ||
|
|
||
| core - Fix ICE in `serializeValueAsJson` when a custom scalar initializer has no recognized constructor (e.g. `S.i()` with no args). Now returns `undefined` instead of crashing. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.