Skip to content

Conversation

maredman
Copy link
Contributor

@dg0yt made a good point that I was missing double quotes in PR #47303 but I missed the comment before the PR closed. This PR addresses that defect.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do like this but I'm not sure it's worth invalidating caches etc. for users. Notably it only has impact if SOURCE_PATH or CURRENT_PACKAGES_DIR contain ;s.

Would be happy to merge this into the next time this port needs to be touched for some other reason though.

@BillyONeal BillyONeal added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Sep 16, 2025
@maredman
Copy link
Contributor Author

@BillyONeal Ah, that makes sense. I wanted to make a good faith effort to address the comment in the other PR, but I'm totally fine with holding off on this until a more substantial change is needed for lastools.

I'm newer to vcpkg - what should I do in this case? Should I just close this PR and write up an issue for this? Something else?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants