Skip to content

Conversation

bbonaby
Copy link
Contributor

@bbonaby bbonaby commented Sep 18, 2025

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

I updated the port to use the new NuGet package in our nuget feed instead of restoring the solution file via nuget restore.

@bbonaby bbonaby marked this pull request as ready for review September 18, 2025 00:58
JavierMatosD
JavierMatosD previously approved these changes Sep 22, 2025
@JavierMatosD JavierMatosD added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Sep 22, 2025
)

vcpkg_install_copyright(FILE_LIST "${SOURCE_PATH}/LICENSE")
vcpkg_copy_tools(TOOL_NAMES edlcodegen SEARCH_DIR "${PACKAGE_PATH}/bin" AUTO_CLEAN)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick, do as you like.

Suggested change
vcpkg_copy_tools(TOOL_NAMES edlcodegen SEARCH_DIR "${PACKAGE_PATH}/bin" AUTO_CLEAN)
vcpkg_copy_tools(TOOL_NAMES edlcodegen SEARCH_DIR "${PACKAGE_PATH}/bin")

PACKAGE_PATH is the extracted binary blob. AUTO_CLEAN isn't needed, and it breaks editable builds. (But who would edit a non-source package.)

@JavierMatosD
Copy link
Contributor

@bbonaby can you explain the motivation for this change?

@JavierMatosD JavierMatosD marked this pull request as draft September 23, 2025 12:00
@bbonaby
Copy link
Contributor Author

bbonaby commented Sep 23, 2025

@JavierMatosD The motivation here is that there is really no need for us to be building the codegen tool from source here. Vbs enclaves themselves only run on x64 and arm64. Since we already ship the tool via nuget with these in it, there isn't a special need to rebuild it.

As an aside, building from source also causes issues in different build pipelines due to its reliance on https://vcpkg.io/en/package/vcpkg-pkgconfig-get-modules.html. A good example is in OSClient, pkgconfig causes build warnings for msvc (due to usage of deprecated apis) in their pipeline which causes the build to fail. To avoid this and anything in the future, since we simply want to distribute the tool here for folks that can't use nuget e.g the OS repo, to me the better way would be to just use the prepackaged nuget.

@JavierMatosD JavierMatosD removed the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants