-
Notifications
You must be signed in to change notification settings - Fork 7.1k
[vbs-enclave-tooling-codegen] Update to 0.1.2-prerelease.250820.1 #47397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
) | ||
|
||
vcpkg_install_copyright(FILE_LIST "${SOURCE_PATH}/LICENSE") | ||
vcpkg_copy_tools(TOOL_NAMES edlcodegen SEARCH_DIR "${PACKAGE_PATH}/bin" AUTO_CLEAN) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick, do as you like.
vcpkg_copy_tools(TOOL_NAMES edlcodegen SEARCH_DIR "${PACKAGE_PATH}/bin" AUTO_CLEAN) | |
vcpkg_copy_tools(TOOL_NAMES edlcodegen SEARCH_DIR "${PACKAGE_PATH}/bin") |
PACKAGE_PATH is the extracted binary blob. AUTO_CLEAN isn't needed, and it breaks editable builds. (But who would edit a non-source package.)
@bbonaby can you explain the motivation for this change? |
@JavierMatosD The motivation here is that there is really no need for us to be building the codegen tool from source here. Vbs enclaves themselves only run on x64 and arm64. Since we already ship the tool via nuget with these in it, there isn't a special need to rebuild it. As an aside, building from source also causes issues in different build pipelines due to its reliance on https://vcpkg.io/en/package/vcpkg-pkgconfig-get-modules.html. A good example is in OSClient, pkgconfig causes build warnings for msvc (due to usage of deprecated apis) in their pipeline which causes the build to fail. To avoid this and anything in the future, since we simply want to distribute the tool here for folks that can't use nuget e.g the OS repo, to me the better way would be to just use the prepackaged nuget. |
./vcpkg x-add-version --all
and committing the result.I updated the port to use the new NuGet package in our nuget feed instead of restoring the solution file via nuget restore.