[vcpkg-make] Add a NO_CONFIGURE option#50141
[vcpkg-make] Add a NO_CONFIGURE option#50141JavierMatosD wants to merge 2 commits intomicrosoft:masterfrom
Conversation
|
This only satisfies the "no configure" case. |
|
It should be possible to use vcpkg_make_install without vcpkg_make_configure. I have the feeling it is only used for the copying of the sources? I mean if you want to go hardcoe you could introduce CONFIGURE_RULE and use similar syntax as cmake's compiler rules to allow injecting custom stuff. |
| set(cm_FLAGS AR AS CC C CCAS CPP CXX FC FF GC LD LF LIBTOOL OBJC OBJXX R RC UPC Y) | ||
|
|
||
| list(TRANSFORM cm_FLAGS APPEND "FLAGS") | ||
| vcpkg_backup_env_variables(VARS |
There was a problem hiding this comment.
It seems like almost all of this is unused given that it seems to be setting up an environment for calling configure?
There was a problem hiding this comment.
I am opposed to a function Xxx_configure having a parameter NO_CONFIGURE which suggests that the function does nothing. (This is one of the worst sins of vcpkg_configure_make which is one of the reasons we introduced vcpkg_make_Xxx in the first place!)
Either:
- The functionality that people actually need should be extracted as a separate function not named
Xxx_configureand people who want this should call that, perhapsvcpkg_make_prepare, or vcpkg_make_buildet al. should be fixed to work ifvcpkg_make_configureis not called first.
(I'm guessing (1) is appropriate but I wouldn't require that)
|
I stopped the build because (1) this is almost a world rebuild, (2) the lab is behind at the moment, and (3) I don't think this should merge as currently written. |
Experimenting with NO_CONFIGURE option for vcpkg-make port. If upstream doesn't supply a configure script than user have to add an empty stub. Motivation -> https://github.com/microsoft/vcpkg/pull/49542/changes#diff-acd6c2d36d562deab8fa57e5842b1423c3fa533140245ece6360247d4c8e3f0a