[odbccpp] Add new port by florsap · Pull Request #50152 · microsoft/vcpkg

florsap · 2026-02-24T08:27:20Z

Changes comply with the maintainer guide.
The packaged project shows strong association with the chosen port name. Check this box if at least one of the following criteria is met:
- The project is amongst the first web search results for "" or " C++". Include a screenshot of the search engine results in the PR.

Optional dependencies of the build are all controlled by the port. A dependency is controlled if it is declared an unconditional dependency in vcpkg.json, or explicitly disabled through patches or build system arguments such as CMAKE_DISABLE_FIND_PACKAGE_Xxx or VCPKG_LOCK_FIND_PACKAGE
The versioning scheme in vcpkg.json matches what upstream says.
The license declaration in vcpkg.json matches what upstream says.
The source code of the component installed comes from an authoritative source.
The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.

florsap · 2026-02-24T08:30:57Z

@microsoft-github-policy-service agree [company="SAP"]

florsap · 2026-02-24T08:31:39Z

@microsoft-github-policy-service agree company="SAP"

This reverts commit 937cdc4.

dg0yt · 2026-02-26T07:07:56Z

ports/odbccpp/vcpkg.json

+  "dependencies": [
+    {
+      "name": "unixodbc",
+      "platform": "linux | osx"


How is ODBC provided on other platforms which are not !windows?

Thanks for taking a look. In general I oriented on nanodbc and freetds, but I took the platform here from the supports config of unixodbc (https://github.com/microsoft/vcpkg/blob/b2f068faf45a3f04145bec0f52a66526ad590227/ports/unixodbc/vcpkg.json). For other platforms it must be provided by the system. Let me know if I miss something, I have no issue to change it to !windows if it makes sense.

dg0yt · 2026-02-26T07:09:29Z

ports/odbccpp/use-vcpkg-unixodbc.patch

+-FIND_PACKAGE(ODBC REQUIRED)
+IF(UNIX)
+    FIND_PACKAGE(unixodbc CONFIG)
+    IF(unixodbc_FOUND)
+        SET(ODBC_TARGET UNIX::odbc)
+    ENDIF()
+ENDIF()
+IF(NOT ODBC_TARGET)
+    FIND_PACKAGE(ODBC REQUIRED)
+    SET(ODBC_TARGET ODBC::ODBC)
+ENDIF()


This must match the dependencies expressed in the manifests. I have more suggestions once the manifest dependency question is answered.

Good point, this is wrongfully adapted. Depending on the result of the other comment, this probably should be IF(LINUX OR APPLE).

This reverts commit af41392.

florsap · 2026-02-27T16:16:03Z

Hey, Odbccpp is an open source wrapper for the odbc api to use in c++. Currently, it is mostly used for two other open source projects GDAL and QGIS, it would be cool for them to have it available in vcpkg.
I hope the change is fine, I tried to orient on available ports and hopefully didn't miss anything in the maintainer guide. Thanks for taking a look and maybe considering it.

JavierMatosD

Tagging team review to discuss the proper find_package call

JavierMatosD · 2026-03-02T22:15:32Z

ports/odbccpp/use-vcpkg-unixodbc.patch

+
+-FIND_PACKAGE(ODBC REQUIRED)
+IF(UNIX)
+    FIND_PACKAGE(unixodbc CONFIG)


Hmm.. https://github.com/microsoft/vcpkg/blob/master/ports/unixodbc/usage#L4 I'll need to consult the team since this ports exports unofficial targets. Tagging vcpkg-team-review

Ok, it seems this is allowed and this should use the vcpkg provided configs instead.

JavierMatosD · 2026-03-02T22:17:14Z

ports/odbccpp/portfile.cmake

+        -DGTEST_FOUND=OFF
+        -DDOXYGEN_FOUND=OFF


Suggested change

-DGTEST_FOUND=OFF

-DDOXYGEN_FOUND=OFF

-DCMAKE_DISABLE_FIND_PACKAGE_GTest=ON

-DCMAKE_DISABLE_FIND_PACKAGE_Doxygen=ON

JavierMatosD · 2026-03-02T22:17:39Z

ports/odbccpp/portfile.cmake

+)
+
+vcpkg_cmake_install()
+


Suggested change

vcpkg_copy_pdbs()

JavierMatosD · 2026-03-02T22:19:20Z

ports/odbccpp/vcpkg.json

+  "dependencies": [
+    {
+      "name": "unixodbc",
+      "platform": "!windows"


The port in vcpkg supports "linux | osx"

florsap added 3 commits February 20, 2026 21:40

Add odbccpp to vcpkg

a7ea7ea

version database

937cdc4

Merge branch 'microsoft:master' into add-odbccpp

c95f982

JavierMatosD marked this pull request as draft February 24, 2026 15:20

florsap added 3 commits February 25, 2026 15:11

Revert "version database"

8810753

This reverts commit 937cdc4.

Fix locations of dlls in windows

b763f24

version database

af41392

dg0yt reviewed Feb 26, 2026

View reviewed changes

florsap added 3 commits February 27, 2026 13:20

Revert "version database"

44e8c9e

This reverts commit af41392.

Remove unecessary dynamic build and exclude android

2ac765b

version database

03d31da

florsap marked this pull request as ready for review February 27, 2026 16:16

florsap marked this pull request as draft February 27, 2026 18:36

florsap marked this pull request as ready for review March 2, 2026 08:14

JavierMatosD requested changes Mar 2, 2026

View reviewed changes

JavierMatosD added requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. and removed requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. labels Mar 2, 2026

JavierMatosD marked this pull request as draft March 2, 2026 22:40

		)

		vcpkg_cmake_install()

Conversation

florsap commented Feb 24, 2026

Uh oh!

florsap commented Feb 24, 2026

Uh oh!

florsap commented Feb 24, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

florsap commented Feb 27, 2026

Uh oh!

JavierMatosD left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants