[tclap] Add CMake package config and exported target for 1.2.5#50199
Draft
miyanyan wants to merge 6 commits intomicrosoft:masterfrom
Draft
[tclap] Add CMake package config and exported target for 1.2.5#50199miyanyan wants to merge 6 commits intomicrosoft:masterfrom
miyanyan wants to merge 6 commits intomicrosoft:masterfrom
Conversation
Contributor
|
Vendoring upstreams build system is typically discouraged. On top of that tclap's website states that version 1.4 is the recommended version for new projects. 1.2 only gets critical bug fixes. There's no good reason to stay on 1.2.5. If |
Contributor
Author
|
ecal will drop tclap in 6.2, maybe the best approach is waiting for the new release, eclipse-ecal/ecal#2518 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.the CMakeLists.txt file is copied from tclap 1.4 version, with vcpkg-specific adjustments for header-only layout and config placement, see https://github.com/DAarno/tclap/blob/1.4/CMakeLists.txt, https://github.com/DAarno/tclap/blob/1.4/include/tclap/CMakeLists.txt
currently I can't update tclap to 1.4 as ecal only support tclap 1.2.5, this pr can solve the tclap problems in #49552