[apsi] Update to 1.0.1 - #54032
Merged
Merged
[apsi] Update to 1.0.1#54032
Conversation
Kim Laine (kimlaine)
marked this pull request as ready for review
September 22, 2026 06:05
Billy O'Neal (BillyONeal)
approved these changes
Sep 22, 2026
Billy O'Neal (BillyONeal)
left a comment
Member
There was a problem hiding this comment.
Thanks for the new version! A few notes from GPT 5.6 Sol:
- APSI's versioned header layout requires consumers to add
include/APSI-1.0; compiling with only the normal vcpkg include root fails when public headers includeapsi/.... This behavior also exists in 0.11.0.
It would be nice to make direct-include work but if upstream doesn't care they don't care.
- Debug consumers of
apsi[hexl]fail to link because the existing HEXL export nameseasyloggingpp.libwithout an imported target or library path. The same failure reproduces with the current 0.11.0 port, so it is not introduced by this update.
This is a hexl bug not an apsi bug so nothing to fix here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.