Remove emulator option for non-windows #1246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nturinski
reviewed
Apr 30, 2019
| if (result === selectAccount) { | ||
| wizardContext.azureWebJobsStorageType = 'azure'; | ||
| } else if (result === useEmulator) { | ||
| wizardContext.azureWebJobsStorageType = 'emulator'; | ||
| } | ||
|
|
||
| // tslint:disable-next-line: strict-boolean-expressions | ||
| wizardContext.actionContext.properties.azureWebJobsStorageType = wizardContext.azureWebJobsStorageType || 'skipForNow'; |
There was a problem hiding this comment.
You already have telemetry on the os right?
There was a problem hiding this comment.
Yeah that's part of the default stuff collected for all events
nturinski
reviewed
Apr 30, 2019
| // Only show on Windows until this is fixed: https://github.com/Microsoft/vscode-azurefunctions/issues/1245 | ||
| buttons.push(useEmulator); | ||
| } | ||
| buttons.push(skipForNow); |
There was a problem hiding this comment.
Should this only have skipForNow if it's not Windows?
There was a problem hiding this comment.
I'm meh on that button, but figured I might as well add it and see what people do in the telemetry. We can remove it if no one picks it
nturinski
approved these changes
Apr 30, 2019
|
FYI I've seen the above message with Azurite if AzureWebJobsDashboard is not specified. If you specify it with a blank "" it doesn't appear. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The emulator story on non-windows is using Azurite - but that has some limitations (see #1245) and probably isn't up-to-par quite yet
Since I'm not showing the emulator, I feel like I need to do a "Skip for now" button
