Change background endspattern to stop at "Application Started" #1428
Conversation
This change will background the task when azure functions is ready to accept connections. This will save a few seconds between the task starting and the debug being available and speed up the developer feedback loop.
|
Hey @JustinGrote , thanks for the PR, we appreciate it! Do you have a before-after gif, or something specific we can repro against to track the effect of this change over time? |
| @@ -721,7 +721,7 @@ | |||
| "background": { | |||
| "activeOnStart": true, | |||
| "beginsPattern": "^.*(Job host stopped|signaling restart).*$", | |||
| "endsPattern": "^.*Host lock lease acquired by instance ID.*$" | |||
| "endsPattern": "^Application started.+$" | |||
There was a problem hiding this comment.
@JustinGrote not sure if you remember, but we already discussed this here.
This may work for some languages, but not all. Specifically Python would fail unless we waited for the lock lease message. See #660
I've asked the functions team to give us a debug-specific message that will work in all languages. See Azure/azure-functions-host#4384
There was a problem hiding this comment.
The message changed so I thought this got resolved but apparently not. My bad :) guess this is stuck on that request.
There was a problem hiding this comment.
If you want to dig deeper and find out exactly when/why/how the message changed that would be great, but yeah at the moment I'm just waiting on that issue
This change will background the task when azure functions is ready to accept connections. This will save a few seconds between the task starting and the debug being available and speed up the developer feedback loop.