Skip to content

Add runtime-specific "$func-watch" and fix PowerShell attach #2465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Conversation

ejizba
Copy link
Contributor

@ejizba ejizba commented Oct 14, 2020

PowerShell doesn't work with the new message "Worker process started and initialized" (added in #2200). We've had other issues in the past where only one language is affected, so I decided to add runtime-specific versions of "func-watch". Since this gets hard-coded in the user's "tasks.json", I want to add one for each runtime now, even though PowerShell is the only one that needs it

Fixes #2460

@ejizba ejizba requested a review from a team as a code owner October 14, 2020 23:20
"base": "$func-watch",
"background": {
"activeOnStart": true,
"beginsPattern": "^.*(Job host stopped|signaling restart).*$",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see it in a quick search, but Func Core Tools aren't localized, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah

@ejizba ejizba merged commit 317385d into main Oct 15, 2020
@ejizba ejizba deleted the ej/watch branch October 15, 2020 21:26
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disconnect the debugger automatically when debugging the PowerShell project
3 participants