Add support for domain name label scopes #4404
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicroFish91
force-pushed
the
mwf/domainNameScopes
branch
from
f6c7341 to
35d5958
Compare
MicroFish91
commented
Mar 11, 2025
| if (!context.advancedCreation) { | ||
| LocationListStep.addStep(wizardContext, promptSteps); | ||
| } else { | ||
| CustomLocationListStep.addStep(wizardContext, promptSteps); |
There was a problem hiding this comment.
Would appreciate a double check on this location logic to make sure these are the scenarios where each type of list step applies
MicroFish91
commented
Mar 12, 2025
| @@ -136,6 +127,147 @@ export class FunctionAppCreateStep extends AzureWizardExecuteStep<IFunctionAppWi | |||
| return site; | |||
| } | |||
|
|
|||
| private async getNewSite(context: IFunctionAppWizardContext, stack: FullFunctionAppStack): Promise<Site> { | |||
There was a problem hiding this comment.
Some of the diff here is showing up as new code, but much of it is just me reorganizing existing code sections and grouping related logic under foldable regions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4390
Changes not applied to containerized function apps.
Related to this appservice pr: microsoft/vscode-azureappservice#2703
Todo: Need to update and fix package/package-lock, but the PR is ready for review.