Add support for domain name label scopes #4532
Conversation
| if (!context.advancedCreation) { | ||
| LocationListStep.addStep(wizardContext, promptSteps); | ||
| } else { | ||
| CustomLocationListStep.addStep(wizardContext, promptSteps); |
There was a problem hiding this comment.
Would appreciate a double check on this location logic to make sure these are the scenarios where each type of list step applies
| return site; | ||
| } | ||
|
|
||
| private async getNewSite(context: IFunctionAppWizardContext, stack?: FullFunctionAppStack): Promise<Site> { |
There was a problem hiding this comment.
Some of the diff here is showing up as new code, but much of it is just me reorganizing existing code sections and grouping related logic under their own foldable regions.
Reorganizing was especially important because we temporarily need to duplicate (double) the number of branching logic paths due to needing to make a manual call without the SDK (which requires forming different shaped site payloads than what we're used to) when tenant DNLS is chosen.
| LocationListStep.addStep(wizardContext, promptSteps); | ||
| } else { | ||
| CustomLocationListStep.addStep(wizardContext, promptSteps); | ||
| promptSteps.push(new ResourceGroupListStep()); |
There was a problem hiding this comment.
One bad experience with resource group list step being here is that even it doesn't use my RG name for anything including the app name. I was kind of expecting an auto complete there.
|
The SDK support for this has officially been released, so we can probably scrap this PR for a newer one, coming soon.... |
Closes #4390
Changes currently N/A for containerized function apps.
Tests: #4535