Skip to content

Add tests for domain name label scopes #4535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: mwf/fragile-apricot
Choose a base branch
from
Open

Add tests for domain name label scopes #4535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cbd6e5d
Update inputs to fix advanced create tests (#4534)
MicroFish91 Jun 4, 2025
5b90153
Add tests
MicroFish91 Jun 5, 2025
16d83cb
Misc
MicroFish91 Jun 5, 2025
9f50744
Merge with main
MicroFish91 Jun 5, 2025
bb3d3c2
Fix a test, remove a duplicate
MicroFish91 Jun 5, 2025
5fe23c1
Add test comment
MicroFish91 Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
144 changes: 144 additions & 0 deletions test/nightly/dnls.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,144 @@
/*---------------------------------------------------------------------------------------------
* Copyright (c) Microsoft Corporation. All rights reserved.
* Licensed under the MIT License. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/

import { type Site } from '@azure/arm-appservice';
import { tryGetWebApp } from '@microsoft/vscode-azext-azureappservice';
import { runWithTestActionContext } from '@microsoft/vscode-azext-dev';
import * as assert from 'assert';
import { createFunctionApp, createFunctionAppAdvanced, deleteFunctionApp, DialogResponses, getRandomHexString, nonNullProp } from '../../extension.bundle';
import { cleanTestWorkspace, longRunningTestsEnabled } from '../global.test';
import { resourceGroupsToDelete, testClient } from './global.nightly.test';

suite('Domain Name Label Scopes (DNLS)', function (this: Mocha.Suite): void {
this.timeout(7 * 60 * 1000);

let basicAppName: string;
let rgName: string;
let saName: string;
let aiName: string;
let aspName: string;
let location: string;

suiteSetup(async function (this: Mocha.Context): Promise<void> {
if (!longRunningTestsEnabled) {
this.skip();
}

// Ensure files/settings from previous tests don't affect this suite
await cleanTestWorkspace();

basicAppName = getRandomHexString();
rgName = getRandomHexString();
saName = getRandomHexString();
aiName = getRandomHexString();
aspName = getRandomHexString();
location = 'East US'; // Don't randomize locations here because some have very restrictive quotas
resourceGroupsToDelete.push(rgName, basicAppName);
});

// NOTE:
// Tenant DNLS apps will include the location as part of the domain name, making it possible for duplicate site names to be created if they are in different locations and resource groups.
// Global DNLS apps will not include the location as part of the domain name. Names for these must be globally unique.

test('Create - Basic - Tenant DNLS', async () => {
const testInputs: (string | RegExp)[] = [location, basicAppName, /\.net/i, 'Managed identity'];
await runWithTestActionContext('createFunctionAppBasicDnls', async context => {
await context.ui.runWithInputs(testInputs, async () => {
await createFunctionApp(context);
});
});
const createdApp: Site | undefined = await tryGetWebApp(testClient, basicAppName, basicAppName);
const domainNameSearch: RegExp = new RegExp(location.replace(/\s+/g, ''), 'i');
assert.ok(createdApp);
assert.match(nonNullProp(createdApp, 'defaultHostName'), domainNameSearch);
});

test('Create - Advanced - Tenant DNLS + Secrets', async () => {
const appName: string = getRandomHexString();
const testInputs: (string | RegExp)[] = [location, '$(plus) Create new resource group', rgName, 'Tenant Scope', appName, 'Flex Consumption', /\.net/i, '4096', '100', 'Secrets', '$(plus) Create new storage account', saName, '$(plus) Create new Application Insights resource', aiName, '$(plus) Create new user assigned identity'];
await runWithTestActionContext('createFunctionAppAdvancedDnls', async context => {
await context.ui.runWithInputs(testInputs, async () => {
await createFunctionAppAdvanced(context);
});
});
const createdApp: Site | undefined = await tryGetWebApp(testClient, rgName, appName);
const domainNameSearch: RegExp = new RegExp(location.replace(/\s+/g, ''), 'i');
assert.ok(createdApp);
assert.match(nonNullProp(createdApp, 'defaultHostName'), domainNameSearch);
});

test('Create - Advanced - Tenant DNLS + Identity', async () => {
const appName: string = getRandomHexString();
const testInputs: (string | RegExp)[] = [location, rgName, 'Tenant Scope', appName, 'App Service Plan', /\.net/i, 'Linux', '$(plus) Create new App Service plan', aspName, 'S1', 'Managed identity', saName, aiName, '$(plus) Create new user assigned identity'];
await runWithTestActionContext('createFunctionAppAdvancedDnls', async context => {
await context.ui.runWithInputs(testInputs, async () => {
await createFunctionAppAdvanced(context);
});
});
const createdApp: Site | undefined = await tryGetWebApp(testClient, rgName, appName);
const domainNameSearch: RegExp = new RegExp(location.replace(/\s+/g, ''), 'i');
assert.ok(createdApp);
assert.match(nonNullProp(createdApp, 'defaultHostName'), domainNameSearch);

// Delete right away to free up quota
await runWithTestActionContext('deleteFunctionApp', async context => {
await context.ui.runWithInputs([appName, DialogResponses.deleteResponse.title, DialogResponses.yes.title], async () => {
await deleteFunctionApp(context);
});
});
});

// Create - Advanced - Tenant DNLS + Identity + Flex
// Skip - already covered under main scenario of `functionAppOperations.test.ts`

test('Create - Advanced - Global DNLS + Secrets', async () => {
const appName: string = getRandomHexString();
const testInputs: (string | RegExp)[] = [location, rgName, 'Global', appName, 'Flex Consumption', /\.net/i, '4096', '100', 'Managed identity', saName, aiName, '$(plus) Create new user assigned identity'];
await runWithTestActionContext('createFunctionAppAdvancedDnls', async context => {
await context.ui.runWithInputs(testInputs, async () => {
await createFunctionAppAdvanced(context);
});
});
const createdApp: Site | undefined = await tryGetWebApp(testClient, rgName, appName);
const domainNameSearch: RegExp = new RegExp(location.replace(/\s+/g, ''), 'i');
assert.ok(createdApp);
assert.doesNotMatch(nonNullProp(createdApp, 'defaultHostName'), domainNameSearch);
});

test('Create - Advanced - Global DNLS + Identity', async () => {
const appName: string = getRandomHexString();
const testInputs: (string | RegExp)[] = [location, rgName, 'Global', appName, 'App Service Plan', /\.net/i, 'Linux', '$(plus) Create new App Service plan', aspName, 'S1', 'Managed identity', saName, aiName, '$(plus) Create new user assigned identity'];
await runWithTestActionContext('createFunctionAppAdvancedDnls', async context => {
await context.ui.runWithInputs(testInputs, async () => {
await createFunctionAppAdvanced(context);
});
});
const createdApp: Site | undefined = await tryGetWebApp(testClient, rgName, appName);
const domainNameSearch: RegExp = new RegExp(location.replace(/\s+/g, ''), 'i');
assert.ok(createdApp);
assert.doesNotMatch(nonNullProp(createdApp, 'defaultHostName'), domainNameSearch);

// Delete right away to free up quota
await runWithTestActionContext('deleteFunctionApp', async context => {
await context.ui.runWithInputs([appName, DialogResponses.deleteResponse.title, DialogResponses.yes.title], async () => {
await deleteFunctionApp(context);
});
});
});

test('Create - Advanced - Global DNLS + Identity + Flex', async () => {
const appName: string = getRandomHexString();
const testInputs: (string | RegExp)[] = [location, rgName, 'Global', appName, 'Flex Consumption', /\.net/i, '4096', '100', 'Managed identity', saName, aiName, '$(plus) Create new user assigned identity'];
await runWithTestActionContext('createFunctionAppAdvancedDnls', async context => {
await context.ui.runWithInputs(testInputs, async () => {
await createFunctionAppAdvanced(context);
});
});
const createdApp: Site | undefined = await tryGetWebApp(testClient, rgName, appName);
const domainNameSearch: RegExp = new RegExp(location.replace(/\s+/g, ''), 'i');
assert.ok(createdApp);
assert.doesNotMatch(createdApp.defaultHostName ?? '', domainNameSearch);
});
});
4 changes: 2 additions & 2 deletions test/nightly/functionAppOperations.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ suite('Function App Operations', function (this: Mocha.Suite): void {
});

test('Create - Advanced', async () => {
const testInputs: (string | RegExp)[] = [appName, 'Flex Consumption', location, /\.net/i, '4096', '100', '$(plus) Create new resource group', rgName, '$(plus) Create new storage account', saName, '$(plus) Create new Application Insights resource', aiName, '$(plus) Create new user assigned identity'];
const testInputs: (string | RegExp)[] = [location, '$(plus) Create new resource group', rgName, 'Tenant Scope', appName, 'Flex Consumption', /\.net/i, '4096', '100', 'Managed identity', '$(plus) Create new storage account', saName, '$(plus) Create new Application Insights resource', aiName, '$(plus) Create new user assigned identity'];
await runWithTestActionContext('createFunctionAppAdvanced', async context => {
await context.ui.runWithInputs(testInputs, async () => {
await createFunctionAppAdvanced(context);
Expand All @@ -51,7 +51,7 @@ suite('Function App Operations', function (this: Mocha.Suite): void {
});

test('Create - Advanced - Existing RG/SA/AI', async () => {
const testInputs: (string | RegExp)[] = [app2Name, 'Flex Consumption', location, /\.net/i, '4096', '100', rgName, saName, aiName, '$(plus) Create new user assigned identity'];
const testInputs: (string | RegExp)[] = [location, rgName, 'Tenant Scope', app2Name, 'Flex Consumption', /\.net/i, '4096', '100', 'Managed identity', saName, aiName, '$(plus) Create new user assigned identity'];
await runWithTestActionContext('createFunctionAppAdvanced', async context => {
await context.ui.runWithInputs(testInputs, async () => {
await createFunctionAppAdvanced(context);
Expand Down