Makes version extraction more robust#306
Merged
karthiknadig merged 2 commits intomicrosoft:mainfrom Sep 5, 2023
Merged
Conversation
karthiknadig
approved these changes
Sep 5, 2023
anthonykim1
approved these changes
Sep 5, 2023
karthiknadig
approved these changes
Sep 5, 2023
Contributor
Author
|
Thank you for merging. When will the next release be that incorporates this change? |
Member
|
This is published in pre-release version 2023.5.12490003 |
Member
|
Stable release will take some time, we usually keep bug-fixes and features on insiders for a milestone. |
Contributor
Author
|
Contributor
Author
|
I see it's pre-released nightly. curious why is there a prefixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we have a wrapper around
blacknamedblack_tool.py, the version string would beand the current version extraction would fail.