feat: wire vscode-common-python-lsp shared package (Stage 1)#730
Merged
Conversation
Replace lsp_utils.py with thin wrapper delegating to shared package. Add ToolConfig to constants.ts. Replace server.ts with shared package delegation. Add vscode-common-python-lsp to bundled libs and npm deps. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- conftest.py: Add bundled/libs to sys.path so test_change_cwd.py can import vscode_common_python_lsp directly. - lsp_utils.py: Fix import ordering to satisfy isort --profile black (aliased imports must be separate statements). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wires the
vscode-common-python-lspshared package into the extension (Stage 1). This replaces duplicated utility code with thin wrappers that delegate to the shared package.Changes
lsp_utils.pywith thin wrapper importing from shared packageToolConfigtoconstants.ts, replaceserver.tswith shared package delegation@vscode/common-python-lsp(npm) andvscode-common-python-lsp==0.3.0(PyPI bundled)Result