fix: stop excluding dist-info from packaged extension#739
Merged
Conversation
Remove the blanket `bundled/libs/*.dist-info/**` exclusion from `.vscodeignore`. Bundled packages may use `importlib.metadata` at runtime to resolve their version (e.g. isort 8.x), which requires `.dist-info` directories to be present. The size impact is negligible (~10-50 KB) and this prevents a class of startup crashes where the LSP server fails with `PackageNotFoundError`. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
edvilme
force-pushed
the
fix/keep-dist-info
branch
from
5bb739b to
bdbb179
Compare
Add a test that calls importlib.metadata.version() against the bundled libs directory. This ensures .dist-info directories are present in the packaged extension. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
edvilme
force-pushed
the
fix/keep-dist-info
branch
from
bdbb179 to
ca1fd64
Compare
StellaHuang95
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Bundled Python packages may use importlib.metadata at runtime to resolve their version string (e.g. isort 8.x uses importlib.metadata.version('isort') in _version.py). This is the modern standard recommended by PEP 566 / PEP 517.
The .vscodeignore has a blanket exclusion �undled/libs/*.dist-info/** that strips all package metadata from the vsix. If any bundled dependency uses importlib.metadata, the LSP server crashes on startup with PackageNotFoundError.
This is currently affecting isort (microsoft/vscode-isort#649) and is a preventive fix for this extension.
Fix
Remove the �undled/libs/*.dist-info/** exclusion. The size impact is negligible (~10-50 KB total) and this future-proofs against any bundled dependency switching to importlib.metadata for versioning.