Skip to content

Establish distinct indexing state in UI for the new UI #10401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #10413
Bernardin-MS opened this issue Jan 19, 2023 · 1 comment · Fixed by #10437
Closed
Tracked by #10413

Establish distinct indexing state in UI for the new UI #10401

Bernardin-MS opened this issue Jan 19, 2023 · 1 comment · Fixed by #10437

Comments

@Bernardin-MS
Copy link
Contributor

Bernardin-MS commented Jan 19, 2023

The Tag Parser Initializing message is still being reported as Indexing with Indexing being reported as Parsing:
image
image

I thought that was going to be fixed?

Originally posted by @sean-mcmanus in #10126 (comment)

@Bernardin-MS Bernardin-MS changed the title The Tag Parser Initializing message is still being reported as Indexing with Indexing being reported as Parsing: Establish distinct indexing state in UI for the new UI Jan 19, 2023
@Bernardin-MS
Copy link
Contributor Author

There is currently no distinction between indexing or not in the updateStatus -> client.ts. This needs to be added in order for the new UI to correctly display when indexing is being done.

@Bernardin-MS Bernardin-MS added bug Language Service enhancement Improvement to an existing feature and removed enhancement Improvement to an existing feature labels Jan 19, 2023
@Bernardin-MS Bernardin-MS self-assigned this Jan 23, 2023
@bobbrow bobbrow linked a pull request Feb 7, 2023 that will close this issue
@bobbrow bobbrow closed this as completed Feb 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants