Skip to content

Move status bar icons into the Language Status #10126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 68 commits into from
Jan 20, 2023
Merged

Conversation

Bernardin-MS
Copy link
Contributor

@Bernardin-MS Bernardin-MS commented Nov 8, 2022

Fixes #8405

@bobbrow bobbrow changed the title Bdezius/8405 Move status bar icons into the Language Status Nov 10, 2022
@bobbrow
Copy link
Member

bobbrow commented Jan 18, 2023

The Tag Parser Initializing message is still being reported as Indexing with Indexing being reported as Parsing: image image

I thought that was going to be fixed?

From what I see in the code, "Indexing Workspace" is only ever present once per session. I know that we can re-index if the database is reset, so there is something wrong here or we don't have enough data coming from the native side to make a determination. Because this PR has been open for so long and this will be a small fix, I think we should just check this in now and then @Bernardin-MS needs to open a bug and fix it in a follow up PR today/tomorrow. Will that work?

@bobbrow
Copy link
Member

bobbrow commented Jan 18, 2023

Actually, I think I identified the issue with @Bernardin-MS and we're looking at a solution. With the old UI, we activate it when we see the first message from the tag parser (which happens to be "Discovering files")

Copy link
Contributor

@sean-mcmanus sean-mcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a bug in which "Parsing Open Files" doesn't go away from the status message after open file parsing is finished if the workspace parsing is paused. This appears to be a regression compared to the previous status bar. It goes away after the Resume is used though.

@Bernardin-MS
Copy link
Contributor Author

@sean-mcmanus after looking into it and a discussion with @bobbrow we're going to deal with showing the Indexing text in a later bug

@Bernardin-MS
Copy link
Contributor Author

Was "Parsing Open Files | Parsing Workspace" supposed to be collapsed to Parsing Workspace (when it's not paused) for V1 or is that for a follow-up?

Should be V2

michelleangela
michelleangela previously approved these changes Jan 19, 2023
michelleangela
michelleangela previously approved these changes Jan 20, 2023
sean-mcmanus

This comment was marked as resolved.

@michelleangela michelleangela merged commit 2d3cac0 into main Jan 20, 2023
@michelleangela michelleangela deleted the bdezius/8405 branch January 20, 2023 21:25
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contribute to the language status
6 participants