-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Move status bar icons into the Language Status #10126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
From what I see in the code, "Indexing Workspace" is only ever present once per session. I know that we can re-index if the database is reset, so there is something wrong here or we don't have enough data coming from the native side to make a determination. Because this PR has been open for so long and this will be a small fix, I think we should just check this in now and then @Bernardin-MS needs to open a bug and fix it in a follow up PR today/tomorrow. Will that work? |
Actually, I think I identified the issue with @Bernardin-MS and we're looking at a solution. With the old UI, we activate it when we see the first message from the tag parser (which happens to be "Discovering files") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a bug in which "Parsing Open Files" doesn't go away from the status message after open file parsing is finished if the workspace parsing is paused. This appears to be a regression compared to the previous status bar. It goes away after the Resume is used though.
@sean-mcmanus after looking into it and a discussion with @bobbrow we're going to deal with showing the Indexing text in a later bug |
Should be V2 |
Fixes #8405