Skip to content

Contribute to the language status #8405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
isidorn opened this issue Nov 16, 2021 · 0 comments · Fixed by #10126
Closed

Contribute to the language status #8405

isidorn opened this issue Nov 16, 2021 · 0 comments · Fixed by #10126
Assignees
Labels
Feature Request fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Milestone

Comments

@isidorn
Copy link

isidorn commented Nov 16, 2021

Hi VS Code PM here 👋

Currently the C++ extension contributes individual items to the status bar. On my macOS I see the Mac item in the status bar. I also see some progress items like the occasional flame icon (pictures).
I suggest to use the language status bar, Typescript is already using this (picture attached).

This way all the C++ status bar items will come under a common item making the whole status bar experience cleaner for our users.

The status bar items which are actually progress our current advise is to use the withProgress-API. With that you announce a long running thing to VS Code. Our current thinking is to add a new progress location which is the extension’s language status. With that we can render something on the composite item as well as on the item itself. This is being discussed here, please chime in.

fyi @bobbrow @jureid @jrieken @egamma

Screenshot 2021-11-15 at 16 46 07

Screenshot 2021-11-16 at 11 34 26

Screenshot 2021-11-16 at 11 36 10

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature Request fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants