Remove use of editorconfig module to avoid dependency on one-ini wasm file.
#12579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
bobbrow
reviewed
Aug 16, 2024
sean-mcmanus
previously approved these changes
Aug 19, 2024
…nto coleng/remove_editorconfig_and_one_ini
sean-mcmanus
approved these changes
Aug 20, 2024
This was referenced Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address: #12529
The
editorconfigmodule was pulling in theone-inimodule, which included a WASM file. Loading of WASM files appears to be a problem (see #12529 ) due to the amount of virtual memory allocated being a problem for systems imposing memory limits.Replaces use of
editorconfiglookup with our own code.