Skip to content

Update to clang-tidy 20.1.0. #13348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions Extension/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -1864,6 +1864,7 @@
"bugprone-assert-side-effect",
"bugprone-assignment-in-if-condition",
"bugprone-bad-signal-to-kill-thread",
"bugprone-bitwise-pointer-cast",
"bugprone-bool-pointer-implicit-conversion",
"bugprone-branch-clone",
"bugprone-casting-through-void",
Expand All @@ -1884,6 +1885,7 @@
"bugprone-inc-dec-in-conditions",
"bugprone-incorrect-*",
"bugprone-incorrect-enable-if",
"bugprone-incorrect-enable-shared-from-this",
"bugprone-incorrect-roundings",
"bugprone-infinite-loop",
"bugprone-integer-division",
Expand All @@ -1902,6 +1904,7 @@
"bugprone-narrowing-conversions",
"bugprone-no-escape",
"bugprone-non-zero-enum-to-bool-conversion",
"bugprone-nondeterministic-pointer-iteration-order",
"bugprone-not-null-terminated-result",
"bugprone-optional-value-conversion",
"bugprone-parent-virtual-call",
Expand Down Expand Up @@ -1935,6 +1938,7 @@
"bugprone-suspicious-stringview-data-usage",
"bugprone-swapped-arguments",
"bugprone-switch-missing-default-case",
"bugprone-tagged-union-member-count",
"bugprone-terminating-continue",
"bugprone-throw-keyword-missing",
"bugprone-too-small-loop-variable",
Expand Down Expand Up @@ -2326,6 +2330,7 @@
"modernize-use-equals-*",
"modernize-use-equals-default",
"modernize-use-equals-delete",
"modernize-use-integer-sign-comparison",
"modernize-use-nodiscard",
"modernize-use-noexcept",
"modernize-use-nullptr",
Expand Down Expand Up @@ -2385,6 +2390,7 @@
"portability-restrict-system-includes",
"portability-simd-intrinsics",
"portability-std-allocator-const",
"portability-template-virtual-member-function",
"readability-*",
"readability-avoid-*",
"readability-avoid-const-params-in-decls",
Expand Down Expand Up @@ -2518,6 +2524,7 @@
"bugprone-assert-side-effect",
"bugprone-assignment-in-if-condition",
"bugprone-bad-signal-to-kill-thread",
"bugprone-bitwise-pointer-cast",
"bugprone-bool-pointer-implicit-conversion",
"bugprone-branch-clone",
"bugprone-casting-through-void",
Expand All @@ -2538,6 +2545,7 @@
"bugprone-inc-dec-in-conditions",
"bugprone-incorrect-*",
"bugprone-incorrect-enable-if",
"bugprone-incorrect-enable-shared-from-this",
"bugprone-incorrect-roundings",
"bugprone-infinite-loop",
"bugprone-integer-division",
Expand All @@ -2556,6 +2564,7 @@
"bugprone-narrowing-conversions",
"bugprone-no-escape",
"bugprone-non-zero-enum-to-bool-conversion",
"bugprone-nondeterministic-pointer-iteration-order",
"bugprone-not-null-terminated-result",
"bugprone-optional-value-conversion",
"bugprone-parent-virtual-call",
Expand Down Expand Up @@ -2589,6 +2598,7 @@
"bugprone-suspicious-stringview-data-usage",
"bugprone-swapped-arguments",
"bugprone-switch-missing-default-case",
"bugprone-tagged-union-member-count",
"bugprone-terminating-continue",
"bugprone-throw-keyword-missing",
"bugprone-too-small-loop-variable",
Expand Down Expand Up @@ -2980,6 +2990,7 @@
"modernize-use-equals-*",
"modernize-use-equals-default",
"modernize-use-equals-delete",
"modernize-use-integer-sign-comparison",
"modernize-use-nodiscard",
"modernize-use-noexcept",
"modernize-use-nullptr",
Expand Down Expand Up @@ -3039,6 +3050,7 @@
"portability-restrict-system-includes",
"portability-simd-intrinsics",
"portability-std-allocator-const",
"portability-template-virtual-member-function",
"readability-*",
"readability-avoid-*",
"readability-avoid-const-params-in-decls",
Expand Down
2 changes: 1 addition & 1 deletion Extension/src/LanguageServer/codeAnalysis.ts
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@ export function publishCodeAnalysisDiagnostics(params: PublishCodeAnalysisDiagno
docPage = `checks${checksGroup}/${checksPage}.html`;
}
// TODO: This should be checking the clang-tidy version used to better support usage of older versions.
const primaryDocUri: vscode.Uri = vscode.Uri.parse(`https://releases.llvm.org/19.1.0/tools/clang/tools/extra/docs/clang-tidy/${docPage}`);
const primaryDocUri: vscode.Uri = vscode.Uri.parse(`https://releases.llvm.org/20.1.0/tools/clang/tools/extra/docs/clang-tidy/${docPage}`);
diagnostic.code = { value: identifier.code, target: primaryDocUri };

if (new CppSettings().clangTidyCodeActionShowDocumentation) {
Expand Down