Skip to content

Add more troubleshooting to linting and formatting for Python #6960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 17, 2024
Merged

Add more troubleshooting to linting and formatting for Python #6960

merged 10 commits into from
Jan 17, 2024

Conversation

luabud
Copy link
Member

@luabud luabud commented Jan 15, 2024 •
edited
Loading

For microsoft/vscode-python#22709

This is to try to tackle some of the feedback we've received for the docs:

  • Not sure how to dismiss the "you have deprecated settings" notifications
  • No "Format Document with" option
  • Formatting and linting are not working even though extensions are installed (e.g. open files only scenarios)

@luabud luabud marked this pull request as ready for review January 15, 2024 21:09
@luabud luabud requested a review from brettcannon January 15, 2024 21:09
@vscodenpa vscodenpa added this to the December / January 2024 milestone Jan 15, 2024
cwebster-99
cwebster-99 reviewed Jan 16, 2024
View reviewed changes
cwebster-99
cwebster-99 reviewed Jan 16, 2024
View reviewed changes
brettcannon
brettcannon previously approved these changes Jan 16, 2024
View reviewed changes
karthiknadig
karthiknadig requested changes Jan 16, 2024
View reviewed changes
luabud and others added 2 commits January 16, 2024 16:02
karthiknadig
karthiknadig previously approved these changes Jan 17, 2024
View reviewed changes
@luabud luabud requested a review from ntrogh January 17, 2024 18:07
@luabud luabud added the python label Jan 17, 2024
ntrogh
ntrogh reviewed Jan 17, 2024
View reviewed changes
ntrogh
ntrogh reviewed Jan 17, 2024
View reviewed changes
ntrogh
ntrogh reviewed Jan 17, 2024
View reviewed changes
ntrogh
ntrogh reviewed Jan 17, 2024
View reviewed changes
ntrogh
ntrogh reviewed Jan 17, 2024
View reviewed changes
ntrogh
ntrogh reviewed Jan 17, 2024
View reviewed changes
@ntrogh
Copy link
Contributor

ntrogh commented Jan 17, 2024

@luabud All good for me. Ready for your final review and merge. Thanks for the updates!

@luabud luabud merged commit 5b2ab33 into microsoft:main Jan 17, 2024
@luabud
Copy link
Member Author

luabud commented Jan 17, 2024

thank you so much @ntrogh!

@luabud luabud mentioned this pull request Jan 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwebster-99 cwebster-99 cwebster-99 left review comments

@ntrogh ntrogh ntrogh approved these changes

@karthiknadig karthiknadig karthiknadig approved these changes

@anthonykim1 anthonykim1 anthonykim1 approved these changes

@brettcannon brettcannon brettcannon left review comments

Assignees

@luabud luabud

Labels
python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@luabud @ntrogh @brettcannon @karthiknadig @cwebster-99 @anthonykim1 @vscodenpa