Skip to content

Download with https proxy if https_proxy is set in environment variable #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Download with https proxy if https_proxy is set in environment variable #14

merged 1 commit into from
Mar 8, 2023

Conversation

Changqing-JING
Copy link
Contributor

Current vscode-dts doesn't work when npm install behind proxy. Add a feature to read https_proxy from environment variable and download via the proxy.

@Changqing-JING
Copy link
Contributor Author

@microsoft-github-policy-service agree

@sean-mcmanus
Copy link

This fixes the issue at microsoft/vscode-cpptools#10631

@sean-mcmanus
Copy link

@connor4312 @jrieken Are you two still maintaining this repo? Do you have an ETA on when this can get reviewed?

@sean-mcmanus
Copy link

@Changqing-JING It seems like the version in package.json may need to be updated to 0.3.4.

@connor4312
Copy link
Member

I would rather use the battle-tested https-proxy-agent module than rolling our own implementation here.

@Changqing-JING
Copy link
Contributor Author

force pushed to use https-proxy-agent

@connor4312 connor4312 enabled auto-merge (squash) March 8, 2023 17:21
@connor4312 connor4312 merged commit 207b895 into microsoft:main Mar 8, 2023
@connor4312
Copy link
Member

Thanks for the PR!

@Changqing-JING
Copy link
Contributor Author

Thank you very much! When is the next release on npm?

@Changqing-JING
Copy link
Contributor Author

@connor4312 Could you help to update v0.3.4 to npm, so that we can use the new version in vscode?

@connor4312
Copy link
Member

Thanks for the ping. I will publish this as @vscode/[email protected] shortly. Please note the package name change -- we are migrating all our packages to the @VScode namespace for security and consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants