Permission error when renaming symbol

[dylankb]

Please direct general questions to:

• Gitter
• Gophers Slack

Please review the Wiki before filing an issue.
Helpful pages include:

• GOPATH
• Module Support
• Debugging
  • Set "trace": "log" and share the resulting logs in the debug console when logging an issue.

Please answer these questions before submitting your issue. Thanks!

What version of Go, VS Code & VS Code Go extension are you using?

• Run go version to get version of Go
  • go version go1.13.5 darwin/amd64
• Run code -v or code-insiders -v to get version of VS Code or VS Code Insiders
  • 1.42.1
    c47d83b293181d9be64f27ff093689e8e7aed054
    x64
• Check your installed extensions to get the version of the VS Code Go extension
• Run go env GOOS GOARCH to get the operating system and processor arhcitecture details
  • darwin amd64

Share the Go related settings you have added/edited

Run Preferences: Open Settings (JSON) command to open your settings.json file.
Share all the settings with the go. or ["go"] prefixes.

Describe the bug

A clear and concise description of what the bug.

When I use the VS Code Rename Symbol functionality a failure message consistently pops up with "Rename failed to compute edits". In the Output tab I see an error string where a permission denied error occurrs with a number of files in $GOPATH/pkg/mod/. I could try changing file permissions with chmod but this seems like it shouldn't be happening in the first place. Here's the error string with some redactions below:

Rename failed: $MY_PATH/go/pkg/mod/google.golang.org/[email protected]/googleapis/rpc/status/status.pb.go:10:8: could not import github.com/golang/protobuf/proto (go/build: importGo github.com/golang/protobuf/proto: exit status 1 error writing go.mod: open $MY_PATH/go/pkg/mod/google.golang.org/[email protected]/go.mod298498081.tmp: permission denied  ) $MY_PATH/go/pkg/mod/google.golang.org/[email protected]/googleapis/rpc/status/status.pb.go:11:6: could not import github.com/golang/protobuf/ptypes/any (go/build: importGo github.com/golang/protobuf/ptypes/any: exit status 1 error writing go.mod: open $MY_PATH/go/pkg/mod/google.golang.org/[email protected]/go.mod298498081.tmp: permission denied  ) $MY_PATH/go/pkg/mod/github.com/golang/[email protected]/ptypes/any.go:42:2: could not import github.com/golang/protobuf/proto (go/build: importGo github.com/golang/protobuf/proto: exit status 1 error writing go.mod: open $MY_PATH/go/pkg/mod/github.com/golang/[email protected]/go.mod298498081.tmp: permission denied  ) $MY_PATH/go/pkg/mod/github.com/golang/[email protected]/ptypes/any.go:43:2: could not import github.com/golang/protobuf/ptypes/any (go/build: importGo github.com/golang/protobuf/ptypes/any: exit status 1 error writing go.mod: open $MY_PATH/go/pkg/mod/github.com/golang/[email protected]/go.mod298498081.tmp: permission denied  ) $MY_PATH/go/pkg/mod/github.com/golang/[email protected]/ptypes/duration.go:42:8: could not import github.com/golang/protobuf/ptypes/duration (go/build: importGo github.com/golang/protobuf/ptypes/duration: exit status 1 error writing go.mod: open $MY_PATH/go/pkg/mod/github.com/golang/[email protected]/go.mod298498081.tmp: permission denied  ) $MY_PATH/go/pkg/mod/github.com/golang/[email protected]/ptypes/timestamp.go:41:7: could not import github.com/golang/protobuf/ptypes/timestamp (go/build: importGo github.com/golang/protobuf/ptypes/timestamp: exit status 1 error writing go.mod: open $MY_PATH/go/pkg/mod/github.com/golang/[email protected]/go.mod298498081.tmp: permission denied  ) $MY_PATH/go/pkg/mod/github.com/golang/[email protected]/ptypes/duration/duration.pb.go:8:8: could not import github.com/golang/protobuf/proto (go/build: importGo github.com/golang/protobuf/proto: exit status 1 error writing go.mod: open $MY_PATH/go/pkg/mod/github.com/golang/[email protected]/go.mod298498081.tmp: permission denied  ) $MY_PATH/go/pkg/mod/github.com/golang/[email protected]/ptypes/timestamp/timestamp.pb.go:8:8: could not import github.com/golang/protobuf/proto (go/build: importGo github.com/golang/protobuf/proto: exit status 1 error writing go.mod: open $MY_PATH/go/pkg/mod/github.com/golang/[email protected]/go.mod298498081.tmp: permission denied  ) $MY_PATH/go/pkg/mod/golang.org/x/[email protected]/trace/histogram.go:17:2: could not import golang.org/x/net/internal/timeseries (go/build: importGo golang.org/x/net/internal/timeseries: exit status 1 error writing go.mod: open $MY_PATH/go/pkg/mod/golang.org/x/[email protected]/go.mod298498081.tmp: permission denied  ) $MY_PATH/go/pkg/mod/golang.org/x/[email protected]/http2/frame.go:17:2: could not import golang.org/x/net/http/httpguts (go/build: importGo golang.org/x/net/http/httpguts: exit status 1 error writing go.mod: open $MY_PATH/go/pkg/mod/golang.org/x/[email protected]/go.mod298498081.tmp: permission denied  ) $MY_PATH/go/pkg/mod/golang.org/x/[email protected]/http2/frame.go:18:2: could not import golang.org/x/net/http2/hpack (go/build: importGo golang.org/x/net/http2/hpack: exit status 1 error writing go.mod: open $MY_PATH/go/pkg/mod/golang.org/x/[email protected]/go.mod298498081.tmp: permission denied  ) $MY_PATH/go/pkg/mod/golang.org/x/[email protected]/http2/transport.go:35:2: could not import golang.org/x/net/idna (go/build: importGo golang.org/x/net/idna: exit status 1 error writing go.mod: open $MY_PATH/go/pkg/mod/golang.org/x/[email protected]/go.mod298498081.tmp: permission denied  ) gorename: couldn't load packages due to errors: github.com/golang/protobuf/ptypes/duration, github.com/golang/protobuf/ptypes, google.golang.org/genproto/googleapis/rpc/status and 3 more

[stamblerre]

Are you using the language server? Renaming without the language server is not supported for projects using modules. You can enable the language server by setting "go.useLanguageServer": true. More details are available here.

[dylankb]

Thanks for the note! I am not using go modules in the project so I do not think I'm using the gopls language server.

…

On Wed, Feb 19, 2020, 11:31 AM Rebecca Stambler ***@***.***> wrote: Are you using the language server? Renaming without the language server is not supported for projects using modules. You can enable the language server by setting "go.useLanguageServer": true. More details are available here <https://github.com/golang/tools/blob/master/gopls/doc/vscode.md>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3058?email_source=notifications&email_token=ACAT6S4FR7TJC2Z6RFSOESTRDWCKVA5CNFSM4KX73VX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMJFYJY#issuecomment-588405799>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACAT6S52ZIJ6CMHZMFVHDYDRDWCKVANCNFSM4KX73VXQ> .

[hyangah]

golang/go#34222

I am guessing gorename is somewhat broken even in (implicit) GOPATH mode since go 1.13. Go1.13 started to enable the module-aware mode when GO111MODULE=auto (https://golang.org/doc/go1.13#modules) and it affects the loading of the packages under GOPATH that have go.mod. Can you try with explicitly setting GO111MODULE=off?

[hyangah]

And gopls should work in GOPATH mode too. So, try the gopls language server when you feel ready.

[dylankb]

Unlike others, setting GO111MODULE=off did not fix the issue. However, switching to the gopls did fix the issue even with GO111MODULE=auto. For some reason I assumed gopls was only for projects using modules. Thanks!