Skip to content

Update output directories of the builds #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 6, 2021

Conversation

DonJayamanne
Copy link
Contributor

  • Plan is to build and upload VSIX to blob store or the like
  • When we build (locally or CI) Jupyter extension download this VSIX, unzip and copy files from output into jupyter extension
  • This way jupyter extsnion will work during dev & build (download assets just as we do with the C++ exe for cryptography)

microsoft/vscode-jupyter#4149
microsoft/vscode-jupyter#3936

…ers into main

* 'main' of github.com:DonJayamanne/vscode-notebook-renderers:
  Update publisher
  Update master to main
…ers into main

* 'main' of github.com:DonJayamanne/vscode-notebook-renderers:
  Update publisher
  Update master to main
@@ -16,7 +16,7 @@ module.exports = {
renderers: './src/client/index.tsx'
},
output: {
path: path.join(constants.ExtensionRootDir, 'out', 'client'),
path: path.join(constants.ExtensionRootDir, 'out', 'client_renderer'),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed target directories so they do not conflict with client & extension folders in the Jupyter extension. Suffixed with _renderer so that we can copy them blindly across to Juypyter extension output directory & not worry about fixing paths.

@rchiodo
Copy link
Contributor

rchiodo commented Jan 6, 2021

I don't see where the renderer extension uploads itself (to the blob storage)? Is that manual for now?

@DonJayamanne
Copy link
Contributor Author

DonJayamanne commented Jan 6, 2021

Is that manual for now?

Yes, didn't add any CI steps for that. If we end up building this often (or next time) then we can, else I didn't see much value in writing that code.

That's why the previous upload to the marketplace was also manual, we just pulled from Azure pipelines and uploaded to marketplace manually (or that was the plan).

@DonJayamanne DonJayamanne merged commit 81d8311 into microsoft:main Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants