Fixes to rendering images #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
May 27, 2021
| : isJson | ||
| ? cellInfo.json() | ||
| : cellInfo.text(); | ||
| const value = isImage ? cellInfo.blob() : isJson ? cellInfo.json() : cellInfo.text(); |
There was a problem hiding this comment.
A more efficient way, using Blob
DonJayamanne
requested review from
joyceerhl,
DavidKutu,
IanMatthewHuff and
rchiodo
rchiodo
reviewed
May 27, 2021
| @@ -51,11 +51,7 @@ function convertVSCodeOutputToExecutResultOrDisplayData( | |||
| ): nbformat.IExecuteResult | nbformat.IDisplayData { | |||
| const isImage = cellInfo.mime.toLowerCase().startsWith('image/'); | |||
| const isJson = cellInfo.mime.toLowerCase().includes('json'); | |||
There was a problem hiding this comment.
I thought the isJson function was wrong?
There was a problem hiding this comment.
Didn't it need to check for actual json? Although I think that's a separate bug.
There was a problem hiding this comment.
yes thats wrong, waiting on @IanMatthewHuff not sure if he's working on a fix for that or not.
This issue fixes the image rendering issue.
rchiodo
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/vscode-jupyter#6002 (comment)
(converting bytes to base64 is an inefficient approach, using native Blobs)