Skip to content

Remove hardcoded white background #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 21, 2021
Merged

Conversation

mohtar
Copy link
Contributor

@mohtar mohtar commented Sep 5, 2021

Make background of .svgContent so that the rendered SVG (especially when %config InlineBackend.figure_format = 'svg' is enabled) works for any chosen background color for the editor.

Make background of .svgContent so that the rendered SVG (especially when `%config InlineBackend.figure_format = 'svg'` is enabled) works for any chosen background color for the editor.
@DonJayamanne
Copy link
Contributor

@mohtar
Thanks the PR, Please could you file an issue on the https://github.com/microsoft/vscode-jupyter repo so we can review the issue first.

@mohtar
Copy link
Contributor Author

mohtar commented Sep 20, 2021

Hmmm src/client/index.css is now deleted by this PR: #59 What happened to it? Did it go to a different repo?

@mohtar
Copy link
Contributor Author

mohtar commented Sep 20, 2021

Anyway, bug filed here

@DonJayamanne
Copy link
Contributor

@mohtar Thanks for filing this issue. Its a duplicate of a few others filed by users.
We have fixed this, the PR you had wasn't the best fix, you can see the fix here #64

Thanks for submitting a PR.
In the future ,please submit an issue when submitting a PR, then we can help with such items,

@DonJayamanne DonJayamanne merged commit e9c87b1 into microsoft:main Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants