-
Notifications
You must be signed in to change notification settings - Fork 38
Add nteract renderers #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Any particular areas of new code that we should be looking at in particular? I'll try to give it all a once over, but if 90% is copied might be good to have some focus on the new stuff. |
|
||
// this method is called when your extension is activated | ||
// your extension is activated the very first time the command is executed | ||
export function activate(context: vscode.ExtensionContext) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this deleted because there's no need for it anymore?
I was wondering if you're going to create an IExtensionApi for this extension that we'd use for the interactive window. I presume it would be returned from the activate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe we just reference the webpack bundle from our extension.
In reply to: 437547845 [](ancestors = 437547845)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this deleted because there's no need for it anymor
agreed
I was wondering if you're going to create an IExtensionApi for this extension that we'd use for the interactive window. I presume it would be returned from the activate?
Later, once I get the initial bit working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
สุดดดดๆไปเลยยพี่ |
Uh oh!
There was an error while loading. Please reload this page.