Skip to content

Add nteract renderers #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 9, 2020
Merged

Add nteract renderers #8

merged 4 commits into from
Jun 9, 2020

Conversation

DonJayamanne
Copy link
Contributor

@DonJayamanne DonJayamanne commented Jun 5, 2020

  • Copied 90% of code from Python extension
  • Uses same old version of nteract as used in python extension
  • Will need to add tests (that will be done separately)
  • Will add notes on how to test this extension

@DonJayamanne DonJayamanne marked this pull request as ready for review June 9, 2020 15:45
@IanMatthewHuff
Copy link
Member

  • Copied 90% of code from Python extension
  • Uses same old version of nteract as used in python extension
  • Will need to add tests (that will be done separately)
  • Will add notes on how to test this extension

Any particular areas of new code that we should be looking at in particular? I'll try to give it all a once over, but if 90% is copied might be good to have some focus on the new stuff.


// this method is called when your extension is activated
// your extension is activated the very first time the command is executed
export function activate(context: vscode.ExtensionContext) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this deleted because there's no need for it anymore?

I was wondering if you're going to create an IExtensionApi for this extension that we'd use for the interactive window. I presume it would be returned from the activate?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe we just reference the webpack bundle from our extension.


In reply to: 437547845 [](ancestors = 437547845)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this deleted because there's no need for it anymor

agreed

I was wondering if you're going to create an IExtensionApi for this extension that we'd use for the interactive window. I presume it would be returned from the activate?

Later, once I get the initial bit working.

Copy link
Contributor

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DonJayamanne DonJayamanne merged commit 65dd70e into microsoft:master Jun 9, 2020
@DonJayamanne DonJayamanne deleted the nteract branch June 9, 2020 17:35
@ToON-01
Copy link

ToON-01 commented Jun 14, 2023

สุดดดดๆไปเลยยพี่

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants