Sync with template: Fix duplicate server handlers on concurrent restarts#705
Merged
Conversation
- Move _disposables cleanup outside if(oldLsClient) in restartServer() so disposables are always cleaned up regardless of prior client state - Wrap lsClient.stop() in try/catch in deactivate() to handle errors during extension deactivation gracefully Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
@copilot Does this use the |
Contributor
8 tasks
rchiodo
reviewed
Feb 25, 2026
edvilme
force-pushed
the
sync/template-pr-259-c8b939bbaa7af851
branch
from
c4613e0 to
31ea12e
Compare
edvilme
added
bug
bschnurr
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
==================================================================
Generated from template microsoft/vscode-python-tools-extension-template#259