Update debug python button #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulacamargo25
added
the
feature-request
|
What's the difference between "Debug Python File" and "Python Debugger: Debug Python File"? |
roblourens
reviewed
Nov 21, 2023
| @@ -5,13 +5,17 @@ import * as path from 'path'; | |||
| import * as fs from 'fs-extra'; | |||
| import { parse } from 'jsonc-parser'; | |||
| import { DebugConfiguration, Uri, WorkspaceFolder } from 'vscode'; | |||
| import { getWorkspaceFolder } from '../../../common/vscodeapi'; | |||
| import { getConfiguration, getWorkspaceFolder } from '../../../common/vscodeapi'; | |||
|
|
|||
| export async function getConfigurationsForWorkspace(workspace: WorkspaceFolder): Promise<DebugConfiguration[]> { | |||
There was a problem hiding this comment.
What do you need to look up launch configs for?
There was a problem hiding this comment.
According to the proposal, we check if there is any configuration already created. If not, we show the user the prompt to create the launch.json
roblourens
approved these changes
Nov 21, 2023
The first one come from the Python Extension and the new one is for the Python Debugger. When we remove the debugger from the python debugger there will only be one. |
|
I would suggest removing the "Python Debugger" prefix from this extension's commands, it seems redundant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed: #137