Skip to content

Add auto start browser as default value #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

paulacamargo25
Copy link
Contributor

No description provided.

@paulacamargo25 paulacamargo25 added the feature-request Request for new features or functionality label Feb 22, 2024
@paulacamargo25 paulacamargo25 added this to the February 2024 milestone Feb 22, 2024
@paulacamargo25 paulacamargo25 self-assigned this Feb 22, 2024
@paulacamargo25 paulacamargo25 marked this pull request as ready for review February 22, 2024 02:27
Copy link
Contributor

@bhavyaus bhavyaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking on the warnings in flaskLaunch.unit.test.ts. Feel free to dismiss my review with a reason if the warnings are ignorable.

@paulacamargo25 paulacamargo25 force-pushed the Add-autoStartBrowser-as-default-value branch from c818808 to 48c916a Compare February 22, 2024 19:47
@paulacamargo25
Copy link
Contributor Author

Blocking on the warnings in flaskLaunch.unit.test.ts. Feel free to dismiss my review with a reason if the warnings are ignorable.

Thanks for the review @bhavyaus, yes the warnings are ignorables. So dont worry.

bhavyaus
bhavyaus previously approved these changes Feb 22, 2024
@paulacamargo25 paulacamargo25 merged commit a8b2b83 into microsoft:main Feb 23, 2024
paulacamargo25 added a commit that referenced this pull request Feb 27, 2024
* Update debugpy version (#220)

* update version of debugpy

* update extension version

* update version

* Adding note to use pre-releases for older versions (#218)

* Adding note for pre-releases for older versions

* Updating note

* Do not create config when esc is hit (#228)

* dont continue if esc is hit

* fix lint

* fix tests

* Add auto start browser as default value (#229)

* Add autoStartBrowser

* fix tests

* fix lint

* fix tests

* Update README.md (#234)

* Keep tag version and debugpy version

* dont update value

---------

Co-authored-by: Courtney Webster <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants