Skip to content

hover.jedi.test failing on windows CI #10357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
karthiknadig opened this issue Feb 28, 2020 · 4 comments
Closed

hover.jedi.test failing on windows CI #10357

karthiknadig opened this issue Feb 28, 2020 · 4 comments
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@karthiknadig
Copy link
Member

karthiknadig commented Feb 28, 2020

  6 failing
  1) Autocomplete Base Tests
       Across files With Unicode Characters:

      AssertionError [ERR_ASSERTION]: Foo not found
      + expected - actual

      -0
      +1
      
      at d:\a\1\s\out\test\languageServers\jedi\autocomplete\base.test.js:187:20

  2) Hover Definition (Jedi)
       Across files:

      AssertionError [ERR_ASSERTION]: Definition length is incorrect
      + expected - actual

      -0
      +1
      
      at d:\a\1\s\out\test\languageServers\jedi\definitions\hover.jedi.test.js:66:20


  3) Hover Definition (Jedi)
       Across files with Unicode Characters:

      AssertionError [ERR_ASSERTION]: Definition length is incorrect
      + expected - actual

      -0
      +1
      
      at d:\a\1\s\out\test\languageServers\jedi\definitions\hover.jedi.test.js:124:20


  4) Hover Definition (Jedi)
       Highlighting Class:

      AssertionError [ERR_ASSERTION]: Definition length is incorrect
      + expected - actual

      -0
      +1
      
      at d:\a\1\s\out\test\languageServers\jedi\definitions\hover.jedi.test.js:192:20


  5) Hover Definition (Jedi)
       Highlight Method:

      AssertionError [ERR_ASSERTION]: Definition length is incorrect
      + expected - actual

      -0
      +1
      
      at d:\a\1\s\out\test\languageServers\jedi\definitions\hover.jedi.test.js:241:20


  6) Hover Definition (Jedi)
       Highlight Multiline Method Signature:

      AssertionError [ERR_ASSERTION]: Definition length is incorrect
      + expected - actual

      -0
      +1
      
      at d:\a\1\s\out\test\languageServers\jedi\definitions\hover.jedi.test.js:301:20

Notify server of test completion with code 1
Notified server of test completion
End Exit Reporter for Mocha.

Error: 6 total failures
@karthiknadig karthiknadig added bug Issue identified by VS Code Team member as probable bug P0 labels Feb 28, 2020
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Feb 28, 2020
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Feb 28, 2020
@ericsnowcurrently
Copy link

Looks like this may be related to the move to Python 3.8 in #10276. My guess is that Jedi isn't working quite right on 3.8 under Windows.

@karthiknadig
Copy link
Member Author

karthiknadig commented Mar 2, 2020

The hover is working on 3.8 with Jedi. it is just the tests that are falling over. For example, the hoverTest.py specifically does this hover (The cursor was on Thread())
image

@ericsnowcurrently
Copy link

Why would the hover work but the tests fail?

@ericsnowcurrently
Copy link

FWIW, I took a stab at diagnosing the problem, but ran out of time. I have a PR up to skip the 6 tests and a P1 issue for fixing them.

ericsnowcurrently added a commit that referenced this issue Mar 3, 2020
(for #10357)

We updated CI to test against 3.8 in #10276. Doing so revealed that some of our Jedi-related tests fail on 3.8, but only on Windows. We're temporarily skipping those tests. The will be fixed in #10399.
@ghost ghost removed the needs PR label Mar 3, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

2 participants